fix: replace deprecated JSONPropertiesContainer with AbstractPropContainer - #2101
Open
nanookclaw wants to merge 2 commits into
Open
nanookclaw wants to merge 2 commits into
nanookclaw wants to merge 2 commits into
Conversation
…ainer Replace deprecated JSONPropertiesContainer usage with AbstractPropContainer in dataproc.py and cluster_inference.py per deprecation warnings. Closes NVIDIA#1898 Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
nanookclaw
force-pushed
the
fix/deprecated-json-properties-container
branch
from
June 8, 2026 13:15
16a6aec to
79b0d19
Compare
|
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
Author
|
Updated at commit The change decodes serialized JSON at the Dataproc instance-description and cluster-inference configuration boundaries while preserving already-decoded inputs. Added focused regression coverage for both forms at each boundary. The Dataproc test exercises Local verification under Python 3.12.3: focused |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces deprecated
JSONPropertiesContainerwithAbstractPropContainerin two files, per the deprecation warnings onAbstractPropertiesContainer,YAMLPropertiesContainer, andJSONPropertiesContainerinprop_manager.py.Changes
dataproc.py(7 call sites):AbstractPropContainerfromspark_rapids_tools.utils.propmanager; keptis_valid_gpu_devicefromprop_managerJSONPropertiesContainer(prop_arg=X, file_load=False)→AbstractPropContainer(props=X)at 5 locations (pricing config, instance descriptions, worker props, master props)pricing_configparameter and_set_zone_from_propssignaturecluster_inference.py(1 call site):AbstractPropContainerJSONPropertiesContainer(cluster_conf, file_load=False)→AbstractPropContainer(props=cluster_conf)All changes follow the
AbstractPropContainerAPI:props=for dict wrapping, matchingget_value/get_value_silentmethod signatures preserved from the parent class.Closes #1898