fix(user_tools): replace deprecated prop containers - #2105
WilliamK112 wants to merge 4 commits into
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
…-prop-container Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
|
One JSON string path still needs to be handled. Could you parse |
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
|
Addressed in 1a91b80. Validation:
|
Description
Replace the remaining in-memory
JSONPropertiesContainerusages in Dataproc and cluster inference withAbstractPropContainer, removing the runtimeDeprecationWarningwhile preserving existing property access and JSON-string handling.The migration now covers:
Regression coverage exercises all four paths, verifies the new container type and existing outputs, and confirms that the deprecated-container warning is not emitted.
Fixes #1898.
Tests
PYTHONPATH=src .venv/bin/python -m pytest -q tests/spark_rapids_tools_ut/test_deprecated_prop_container.py(4 passed).venv/bin/python -m pylint -d fixme --load-plugins pylint_pydantic --rcfile=../.pylintrc src/spark_rapids_pytools/cloud_api/dataproc.py src/spark_rapids_pytools/common/cluster_inference.py tests/spark_rapids_tools_ut/test_deprecated_prop_container.py(10.00/10).venv/bin/python -m flake8 src/spark_rapids_pytools/cloud_api/dataproc.py src/spark_rapids_pytools/common/cluster_inference.py tests/spark_rapids_tools_ut/test_deprecated_prop_container.py.venv/bin/python -m py_compile src/spark_rapids_pytools/cloud_api/dataproc.py src/spark_rapids_pytools/common/cluster_inference.py tests/spark_rapids_tools_ut/test_deprecated_prop_container.pygit diff --check upstream/dev...HEAD