Fix cache-derived maxPartitionBytes recommendations - #2124
Merged
parthosa merged 10 commits intoAug 31, 2026
Merged
Conversation
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
parthosa
marked this pull request as ready for review
August 9, 2026 04:30
Signed-off-by: Partho Sarthi <psarthi@nvidia.com>
Collaborator
|
@parthosa for these new AutoTuner enhancements - can we have some sort of numbers around the improvements with these recommendations. |
…partition-bytes Signed-off-by: Partho Sarthi <psarthi@nvidia.com> # Conflicts: # core/src/test/scala/com/nvidia/spark/rapids/tool/tuning/BaseAutoTunerSuite.scala # core/src/test/scala/com/nvidia/spark/rapids/tool/tuning/ProfilingAutoTunerSuiteV2.scala
…partition-bytes Signed-off-by: Partho Sarthi <psarthi@nvidia.com> # Conflicts: # core/src/test/scala/com/nvidia/spark/rapids/tool/tuning/BaseAutoTunerSuite.scala
Collaborator
Author
|
cc: @zpuller Could you please help review this? |
zpuller
approved these changes
Aug 28, 2026
SYangster
approved these changes
Aug 31, 2026
parthosa
added a commit
to parthosa/spark-rapids-tools
that referenced
this pull request
Aug 31, 2026
…le-autotuning Brings in the cache-derived maxPartitionBytes work (NVIDIA#2124). Two conflicts with this branch, both in the AutoTuner test scaffolding: getMockInfoProvider's constructor call gained maxFileScanInputOverride on dev and shuffleStageInputAnalysis here. Both are kept, ordered to match the AppInfoProviderMockTest signature the merge already produced. FileScanInputMetricsSuite's TestProfilingProvider is built with a null ApplicationInfo, so the downward pass added on this branch dereferenced null when it read the shuffle-stage input analysis through it. The stub now overrides that accessor to report no analysis, matching how it already stubs getClassPathEntries for the same reason. Only the test scaffold is affected: the field is genuinely present in production. Signed-off-by: Partho Sarthi <psarthi@nvidia.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2122
Summary
spark.sql.files.maxPartitionBytesonly from final, non-cache datasource scan stages.Testing