fix(user_tools): handle zero-worker Databricks clusters - #2160
Closed
WilliamK112 wants to merge 1 commit into
Closed
fix(user_tools): handle zero-worker Databricks clusters#2160WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
Signed-off-by: Ching-Wei Kang <ckang53@wisc.edu>
|
Collaborator
|
duplicate of #2148 |
Contributor
Author
|
Thanks for pointing that out — I missed #2148 when checking for overlap. It covers the same zero-worker handling, so closing this duplicate makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize a missing Databricks
executorsfield to an empty list in both the AWS and Azure cluster implementations. This lets zero-worker/single-node cluster initialization finish cleanly and reach the existingClusterBase._verify_workers_existvalidation instead of failing earlier with aTypeErrorwhile iterating overNone.The change deliberately preserves the current policy of rejecting driver-only clusters; adding support for that cluster shape remains out of scope.
The regression test covers both platforms using the existing Databricks fixtures with
executorsremoved andnum_workersset to zero, and verifies the intended "no worker nodes" error.Closes #2143.
Validation
Run from
user_toolson currentdev(bcda54d):PYTHONPATH=src python -m pytest tests/spark_rapids_tools_ut/test_cluster.py -q— 9 passedpy_compileon the two implementations and regression testgit diff --check upstream/dev...HEAD