Document PerfIO S3 client configuration - #15943
Open
gerashegalov wants to merge 1 commit into
Open
Conversation
Document the existing PerfIO S3 HTTP client backend selector and the new request timeout settings. Remove PerfIO-only Iceberg S3 declarations from the core configuration registry while retaining their generated user documentation. Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Contributor
Greptile SummaryThis PR aligns the advanced configuration reference with PerfIO’s S3 client configuration and removes duplicate PerfIO-only entries from the core
Confidence Score: 5/5The PR appears safe to merge; no concrete behavioral, documentation, security, or repository-rule issue remains. The removed typed entries have no repository callers, and raw PerfIO settings continue to propagate through the prefix-filtered RAPIDS configuration map while configuration documentation is sourced through the generator’s local and classpath-provided metadata. Important Files Changed
Reviews (1): Last reviewed commit: "Document PerfIO S3 client configuration" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15919.
Description
The PerfIO S3 reader supports selecting Netty or CRT with the existing
spark.rapids.perfio.s3.httpClientsetting, but that setting was omitted from the generatedadvanced configuration documentation. The Iceberg S3 async tuning settings are specific to
PerfIO and should not be declared as core
RapidsConfentries.This change:
and default;
with backend-neutral descriptions where appropriate; and
retaining their generated user documentation.
The existing configuration names and defaults are unchanged.
Validation:
./build/buildall --clean --profile=350 --module=dist --parallel=64 --option='-DskipTests'git diff --checkPerformance testing is not required because this change only updates configuration metadata and
documentation; it does not alter request execution.
AI assistance: the implementation and validation were performed with Codex assistance and
reviewed by the author before publication.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance