Skip to content

Migrate stream APIs from rmm::cuda_stream_view to cuda::stream_ref #23929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdice wants to merge 3 commits into
base: release/26.10
Choose a base branch
from
+9 −9
Open

Migrate stream APIs from rmm::cuda_stream_view to cuda::stream_ref #23929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
333c065
Adapt stream accessors to cuda::stream_ref
bdice Sep 1, 2026
5347e1c
Use cuda::stream_ref in reader_impl_dict_transcode.cu
bdice Sep 2, 2026
1e03a9c
Fix remaining cuda::stream_ref build errors
bdice Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/libcudf_streaming/src/bloom_filter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ rapidsmpf::streaming::Actor bloom_filter::apply(
auto storage = (co_await bloom_filter->receive()).release<rmm::device_buffer>();
RAPIDSMPF_EXPECTS((co_await bloom_filter->receive()).empty(),
"Bloom filter channel contained more than one message");
auto stream = cuda::stream_ref{storage.stream().get()};
auto stream = storage.stream();
rapidsmpf::CudaEvent event;
auto filter = cudf_streaming::detail::device_bloom_filter(filter_size_, seed_, storage.data());
auto meta = co_await ch_in->receive_metadata();
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/io/parquet/reader_impl_dict_transcode.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ void remap_dict_indices_by_chunk(cudf::device_span<int32_t> indices,
cudf::device_span<size_type const> row_offsets,
cudf::device_span<size_type const> key_counts_prefix,
cudf::device_span<int32_t const> stacked_to_unique,
rmm::cuda_stream_view stream)
cuda::stream_ref stream)
{
thrust::for_each(
rmm::exec_policy_nosync(stream, get_current_device_resource_ref()),
Expand Down
12 changes: 6 additions & 6 deletions python/cudf_streaming/cudf_streaming/partition_utils.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ cpdef size_t partition_and_pack_cost(
--------
cudf_streaming.partition_utils.partition_and_pack
"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef table_view tbl = table.view()
cdef size_t ret
Expand Down Expand Up @@ -177,7 +177,7 @@ cpdef object partition_and_pack(
pylibcudf.contiguous_split.pack
cudf_streaming.partition_utils.split_and_pack
"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef vector[size_type] _columns_to_hash = tuple(columns_to_hash)
cdef unordered_map[uint32_t, cpp_PackedData] _ret
Expand Down Expand Up @@ -244,7 +244,7 @@ cpdef size_t split_and_pack_cost(
--------
cudf_streaming.partition_utils.split_and_pack
"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef table_view tbl = table.view()
cdef size_t ret
Expand Down Expand Up @@ -299,7 +299,7 @@ cpdef object split_and_pack(
pylibcudf.copying.split
cudf_streaming.partition_utils.partition_and_pack
"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef vector[size_type] _splits = tuple(splits)
cdef unordered_map[uint32_t, cpp_PackedData] _ret
Expand Down Expand Up @@ -463,7 +463,7 @@ cpdef object unpack_and_concat(
cudf_streaming.partition_utils.unpack_and_concat_cost
cudf_streaming.partition_utils.partition_and_pack
"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef vector[cpp_PackedData] _partitions = _partitions_py_to_cpp(partitions)
cdef unique_ptr[cpp_table] _ret
Expand Down Expand Up @@ -550,7 +550,7 @@ cpdef object packed_data_from_cudf_packed_columns(
"""
if packed_columns is None or stream is None or br is None:
raise TypeError("Arguments must not be None")
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_BufferResource* _br = br.ptr()
cdef PackedData ret = PackedData.__new__(PackedData)
with nogil:
Expand Down
2 changes: 1 addition & 1 deletion python/cudf_streaming/cudf_streaming/table_chunk.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ cdef class TableChunk:
persists even when the chunk is transferred through Channels.

"""
cdef stream_ref _stream = stream_ref(stream.view().get())
cdef stream_ref _stream = stream.view()
cdef cpp_table_view view = table.view()
return TableChunk.from_handle(
cpp_from_table_view_with_owner(
Expand Down
Loading