Skip to content

TEST: Target timezone DST edge cases - #24017

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:codex/target-timezone-dst-edge-cases
Sep 8, 2026
Merged

TEST: Target timezone DST edge cases#24017
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
vyasr:codex/target-timezone-dst-edge-cases

Conversation

@vyasr

@vyasr vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Description

Keep ordinary timezone localization exhaustive over every compatible zone. Run ambiguous and nonexistent-time handling only for zones whose offsets differ for the exact timestamps under test; non-transition zones otherwise duplicate the ordinary-localization coverage.

Coverage accounting

  • Ordinary localization remains exhaustive over all zones.
  • Each DST-edge fixture includes every zone with a transition in its tested timestamp set, plus UTC as a non-transition control.
  • America/Metlakatla and America/Grand_Turk remain in their respective fixtures so the existing expected failures stay covered.

Checklist

  • I am familiar with the CONTRIBUTING.md guidelines.
  • New or existing tests cover these test-only changes.
  • Documentation updates are not needed.

@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue labels Sep 6, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2026
@vyasr

vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr
vyasr marked this pull request as ready for review September 8, 2026 15:42
@vyasr
vyasr requested a review from a team as a code owner September 8, 2026 15:42
@vyasr
vyasr requested a review from Matt711 September 8, 2026 15:42
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7f10ecea-b4b1-4139-94c3-9270087a6862

📥 Commits

Reviewing files that changed from the base of the PR and between a8ad204 and 278932b.

📒 Files selected for processing (2)
  • python/cudf/cudf/tests/conftest.py
  • python/cudf/cudf/tests/series/accessors/test_dt.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded timezone localization coverage for ambiguous and nonexistent local times.
    • Added transition-aware timezone scenarios, including consistent coverage for key time zones and UTC.
    • Improved expected-result handling across timezone implementations.

Walkthrough

Changes

Timezone localization coverage

Layer / File(s) Summary
Transition-aware timezone fixtures
python/cudf/cudf/tests/conftest.py
Added detection for timezone offset transitions and fixtures for ambiguous and nonexistent local times. Updated the SPDX year range.
Datetime localization test integration
python/cudf/cudf/tests/series/accessors/test_dt.py
Updated localization tests to use dedicated fixtures and construct pandas expectations with zoneinfo.ZoneInfo.

Priority: ⬇️ Low — Defer the timezone test fixture change because it is a narrow update to DST edge-case coverage without elevated product or external urgency.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 27893

Timezone localization tests now focus ambiguous and nonexistent-time cases on relevant transition zones while retaining required fallback and UTC coverage. No current merge-blocking risk is identified.

Suggested reviewers: galipremsagar, mroeschke

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: testing timezone daylight-saving-time edge cases.
Description check ✅ Passed The description directly explains the timezone fixture changes, coverage goals, and retained expected failures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit d2836f3 into NVIDIA:main Sep 8, 2026
119 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 8, 2026
@vyasr
vyasr deleted the codex/target-timezone-dst-edge-cases branch September 8, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants