TEST: Target timezone DST edge cases - #24017
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughChangesTimezone localization coverage
Priority: ⬇️ Low — Defer the timezone test fixture change because it is a narrow update to DST edge-case coverage without elevated product or external urgency. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Timezone localization tests now focus ambiguous and nonexistent-time cases on relevant transition zones while retaining required fallback and UTC coverage. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Description
Keep ordinary timezone localization exhaustive over every compatible zone. Run ambiguous and nonexistent-time handling only for zones whose offsets differ for the exact timestamps under test; non-transition zones otherwise duplicate the ordinary-localization coverage.
Coverage accounting
Checklist