Skip to content

TEST: Reduce redundant numerical test matrices - #24019

Open
vyasr wants to merge 4 commits into
NVIDIA:mainfrom
vyasr:codex/reduce-redundant-numerical-test-matrices
Open

TEST: Reduce redundant numerical test matrices#24019
vyasr wants to merge 4 commits into
NVIDIA:mainfrom
vyasr:codex/reduce-redundant-numerical-test-matrices

Conversation

@vyasr

@vyasr vyasr commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Description

Replace covariance/correlation’s redundant operand Cartesian product with nine explicit representative pairs, and remove an unused parameter from one masked-binary execution test.

Coverage accounting

  • The pairs retain normal and integer inputs, constant and all-null values, nullable arrays, Arrow input, empty input, and singleton input.
  • The indexed-Series pair uses the same three labels in a different order on both sides, retaining multi-row index-alignment behavior rather than only a singular/NaN outcome.
  • The same pairs run for covariance and both Pearson and Spearman correlation (189 items to 27).
  • The removed extension-compilation type parameter was not consumed by the test: every former node executed the same integer-scalar kernel.

Checklist

  • I am familiar with the CONTRIBUTING.md guidelines.
  • New or existing tests cover these test-only changes.
  • Documentation updates are not needed.

@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue labels Sep 6, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2026
@vyasr

vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr

vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr
vyasr marked this pull request as ready for review September 9, 2026 00:29
@vyasr
vyasr requested a review from a team as a code owner September 9, 2026 00:30
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5bd89779-3692-4931-807b-91898f72b0d9

📥 Commits

Reviewing files that changed from the base of the PR and between a8ad204 and e111ba5.

📒 Files selected for processing (2)
  • python/cudf/cudf/tests/private_objects/test_extension_compilation.py
  • python/cudf/cudf/tests/series/methods/test_cov_corr.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Simplified masked binary operation test parameters.
    • Consolidated covariance and correlation tests around shared paired test data.
    • Expanded named test scenarios covering nullable, Arrow-backed, indexed, empty, singleton, and reversed-type inputs.

Walkthrough

The changes revise covariance and correlation test inputs to use shared paired cases and simplify masked binary test parameterization by removing numeric type variation.

Changes

Covariance and correlation test data

Layer / File(s) Summary
Shared covariance and correlation inputs
python/cudf/cudf/tests/series/methods/test_cov_corr.py
Adds named paired input cases for covariance and correlation tests. Updates the correlation test to use the shared data set and updates the SPDX attribution.

Masked binary test parameters

Layer / File(s) Summary
Masked binary parameter simplification
python/cudf/cudf/tests/private_objects/test_extension_compilation.py
Removes the numeric type parameter from test_execute_masked_binary.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e111b

This change reduces redundant covariance, correlation, and masked-binary test parameterization while preserving the represented behavior cases. No current merge-blocking risk is identified.

Suggested reviewers: mroeschke

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: reducing redundant numerical test matrices. It is concise and related to the changeset.
Description check ✅ Passed The description accurately explains the reduced covariance and correlation test matrix and the removal of the unused parameter.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant