Skip to content

TEST: Focus logical binop coverage - #24030

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
vyasr:codex/focus-logical-binop-coverage
Sep 8, 2026
Merged

TEST: Focus logical binop coverage#24030
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
vyasr:codex/focus-logical-binop-coverage

Conversation

@vyasr

@vyasr vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Replace redundant logical binary-operation Cartesian products with representative scalar and Series cases. The parameter sets retain both null states, every scalar category, and the fill-value behavior under test.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Existing tests cover these test-only changes.
  • Documentation updates are not needed.

@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 8, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr
vyasr marked this pull request as ready for review September 8, 2026 20:42
@vyasr
vyasr requested a review from a team as a code owner September 8, 2026 20:42
@vyasr
vyasr requested a review from mroeschke September 8, 2026 20:42
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 956ef66e-49a3-4dfa-a6ca-dec4d2a76f30

📥 Commits

Reviewing files that changed from the base of the PR and between 34f116a and f2e615c.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/series/test_binops.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Refined logical binary-operation test coverage to use explicit parameter combinations.
    • Preserved validation for scalar, null, NaN, and fill-value scenarios across series operations.

Walkthrough

The PR updates two logical binary-operation tests to use explicit parameter combinations. The tests retain selected scalar, null, NaN, and fill_value cases for series-series and series-scalar operations.

Changes

Logical binary-operation test coverage

Layer / File(s) Summary
Explicit test cases
python/cudf/cudf/tests/series/test_binops.py
The series-series and series-scalar tests now use eight explicit parameter combinations instead of Cartesian-product parametrization.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f2e61

This updates logical Series binary-operation tests to use representative explicit cases while retaining the intended coverage. No current merge-blocking risk is identified.

Suggested reviewers: galipremsagar, bdice

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies a test-focused change to logical binary-operation coverage, which matches the main changeset.
Description check ✅ Passed The description accurately summarizes the replacement of redundant Cartesian-product parameterizations with representative logical binary-operation cases and explains the retained coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit b0409de into NVIDIA:main Sep 8, 2026
146 of 152 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 8, 2026
@vyasr
vyasr deleted the codex/focus-logical-binop-coverage branch September 8, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants