Skip to content

TEST: Focus concat input matrices - #24032

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
vyasr:codex/focus-concat-input-coverage
Sep 8, 2026
Merged

TEST: Focus concat input matrices#24032
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
vyasr:codex/focus-concat-input-coverage

Conversation

@vyasr

@vyasr vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Replace broad DataFrame concat input Cartesian products with representative input pairs. The selected cases retain distinct DataFrame/Series/list shapes, dtypes, column names, index forms, and existing-buffer behavior.

Checklist

  • I am familiar with the Contributing Guidelines.
  • Existing tests cover these test-only changes.
  • Documentation updates are not needed.

@vyasr vyasr added tests Unit testing for project Python Affects Python cuDF API. Performance Performance related issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 8, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr
vyasr marked this pull request as ready for review September 8, 2026 20:42
@vyasr
vyasr requested a review from a team as a code owner September 8, 2026 20:42
@vyasr
vyasr requested a review from galipremsagar September 8, 2026 20:42
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 84f257e7-c901-495f-a26d-7f72699c5799

📥 Commits

Reviewing files that changed from the base of the PR and between 34f116a and 71f4a08.

📒 Files selected for processing (1)
  • python/cudf/cudf/tests/reshape/test_concat.py

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Expanded concatenation test coverage for empty, indexed, overlapping, and repeated DataFrame combinations.
    • Consolidated reusable test scenarios while preserving existing behavior and test interfaces.
    • No user-facing functionality or production behavior changed.

Walkthrough

The concatenation tests now define reusable DataFrame and input collections at module scope. Parameterized tests reference these collections and add explicit indexed, empty, overlapping, and repeated DataFrame combinations.

Changes

Concatenation test parameterization

Layer / File(s) Summary
List-input test collections
python/cudf/cudf/tests/reshape/test_concat.py
test_dataframe_concat_lists and test_dataframe_concat_dataframe_lists use reusable collections. The cases include indexed, empty, overlapping, and repeated DataFrames.
DataFrame-input test collections
python/cudf/cudf/tests/reshape/test_concat.py
test_dataframe_concat_dataframe uses reusable DataFrame and single-DataFrame collections while preserving existing input combinations.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 71f4a

This updates DataFrame concat test inputs to reusable representative collections without changing production behavior. No current merge-blocking risk remains.

Suggested reviewers: bdice, mroeschke

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the test-only change: it narrows DataFrame concat inputs to representative pairs while preserving coverage across input types, shapes, dtypes, column names, index form…
Title check ✅ Passed The title accurately summarizes the main change by stating that concat test input matrices are being focused. It is concise and specific enough for the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@mroeschke mroeschke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits: OK in a follow up

)


_DATAFRAME_LIST_DFS = [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Not really fond of these _DATAFRAME_* variables defined once for 1 test. When I was refactoring tests, I preferred inlining to reduce indirection as these are relatively "frozen"

),
pd.DataFrame({"first_col": [], "second_col": [], "third_col": []}),
],
pytest.param(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in your other PR, these pytest.params are superfluous and below too

@vyasr

vyasr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 2062f4d into NVIDIA:main Sep 8, 2026
145 of 151 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 8, 2026
@vyasr
vyasr deleted the codex/focus-concat-input-coverage branch September 8, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Performance Performance related issue Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants