Remove fragile explicit import that breaks with jextract/CUDA changes#2124
Conversation
… changes There is no guarantee that any particular declaration will end up in `headers_h` vs `headers_h_1` due to the unstable nature of that split. An explicit import of `cudaStreamSynchronize` is unnecessary since `headers_h` inherits from `headers_h_1`, and therefore that function is already covered by the wildcard import. Fixes NVIDIA#2123
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
Note: This release contains no visible end-user changes; it is a code maintenance update. WalkthroughThis PR removes a redundant static import statement from ChangesImport Statement Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok to test 9ef996c |
|
/ok to test 63cfcfe |
|
/merge |
…NVIDIA#2124) There is no guarantee that any particular declaration will end up in `headers_h` vs `headers_h_1` due to the unstable nature of that split. An explicit import of `cudaStreamSynchronize` is unnecessary since `headers_h` inherits from `headers_h_1`, and therefore that function is already covered by the wildcard import. Fixes NVIDIA#2123 Authors: - Igor Motov (https://github.com/imotov) - Corey J. Nolet (https://github.com/cjnolet) - Tarang Jain (https://github.com/tarang-jain) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: NVIDIA#2124
There is no guarantee that any particular declaration will end up in
headers_hvsheaders_h_1due to the unstable nature of that split. An explicit import ofcudaStreamSynchronizeis unnecessary sinceheaders_hinherits fromheaders_h_1, and therefore that function is already covered by the wildcard import.Fixes #2123