Skip to content

fix the default values for helm chart#444

Merged
nccurry merged 3 commits into
NVIDIA:mainfrom
runzhliu:patch-2
Mar 30, 2026
Merged

fix the default values for helm chart#444
nccurry merged 3 commits into
NVIDIA:mainfrom
runzhliu:patch-2

Conversation

@runzhliu
Copy link
Copy Markdown
Contributor

No description provided.

@nccurry nccurry added the helm label Mar 30, 2026
@nccurry
Copy link
Copy Markdown
Collaborator

nccurry commented Mar 30, 2026

@runzhliu Thanks for the PR!
I updated your fork to the latest and updated the change to set the default explicitly in the values file, rather than rely on the default in the helm chart.

This way, when we set priorityClassName to an empty string, we'll actually unset it in the rendered helm chart, rather than set it implicitly to system-node-critical

@nccurry nccurry merged commit 1f03e25 into NVIDIA:main Mar 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants