Skip to content

fix(metrics): unsupported character in float while parsing #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tongyangyeyue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metrics): unsupported character in float while parsing #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/pkg/collector/gpu_collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ func toMetric(
attrs["err_msg"] = unknownErr
}
}
if val.FieldType == dcgm.DCGM_FT_STRING {
attrs[counter.FieldName] = v // converse string value in prometheus to label , prometheus can't accept string type in value
v = "1" //set value to number, 1 don't mean anything
}

m := Metric{
Counter: counter,
Expand Down Expand Up @@ -366,6 +370,9 @@ func toString(value dcgm.FieldValue_v1) string {
default:
return v
}
case dcgm.DCGM_FT_BINARY:
// I don't know how to convert this variable, I try to value.String() but result is empty
return value.String()
}

return FailedToConvert
Expand Down