fix: account for partially-allocated gpus#644
Closed
pintohutch wants to merge 1 commit into
Closed
Conversation
Fixes the issue mentioned in NVIDIA#549 (comment). Given KUBERNETES_VIRTUAL_GPUS is enabled: When the Kubernetes pod-mapping builds the set of new metrics, we previously ignored the case where some devices were allocated, while others were not. So we add a check to each device lookup, where if there are no associated pods, we copy over the "pod-less" metrics to the final map. Signed-off-by: Daniel Clark <danielclark@google.com>
Collaborator
|
Can you rebase this on the latest in main? |
Collaborator
|
@pintohutch thanks for this contribution. We're closing this PR since the functionality is covered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in
#549 (comment).
Given KUBERNETES_VIRTUAL_GPUS is enabled:
When the Kubernetes pod-mapping builds the set of new metrics, we previously ignored the case where some devices were allocated, while others were not. So we add a check to each device lookup, where if there are no associated pods, we copy over the "pod-less" metrics to the final map.