Repository navigation
Add Nemotron-3 diarization - #11
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
ONNX export and validation asr/diarization/model_export/*, asr/diarization/README.md, THIRD_PARTY_NOTICES.md |
Adds log-mel processing and streaming model export, checkpoint-to-ONNX export, and validation against NeMo and native outputs. Documents export, validation, model behavior, and licensing. |
C++ diarization runtime asr/diarization/diarization.h, asr/diarization/diarization.cpp, asr/diarization/CMakeLists.txt, CMakeLists.txt, asr/diarization/README.md |
Adds the Config, Segment, Result, and Pipeline APIs. The pipeline runs chunked inference, produces speaker segments, and supports speaker lookup by interval. Adds the library to the CMake build. |
CLI and ASR alignment asr/diarization/main.cpp, asr/diarization/CMakeLists.txt, asr/diarization/README.md |
Adds a CLI for diarization with optional Qwen3 transcription and forced alignment. Aligned word timestamps include the speaker returned by Result::SpeakerAt. |
Priority:
Estimated code review effort: 4 (Complex) | ~60 minutes
Merge Risk: 
Minimal · previous review b43f0
-
This change adds the diarization library to the build using the same declaration pattern the existing Whisper and Qwen3 libraries already use. Configuration is not expected to break, and no blocking issue remains in the reviewed change.
Pre-merge checks: 
3 · 
1
-
Failed checks: 1 inconclusive Passed checks: 3 passed -
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Signed-off-by: contentis <luca.mspindler@gmail.com>
697f49d to
be50dc4
Compare
No description provided.