Skip to content

Add Nemotron-3 diarization - #11

Merged
contentis merged 1 commit into
mainfrom
nemotron-diarization
Oct 27, 2026
Merged

contentis merged 1 commit into
mainfrom
nemotron-diarization

Conversation

@contentis

Copy link
Copy Markdown
Collaborator

No description provided.

@contentis
contentis added this pull request to stack #7 September 24, 2026 08:07
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d7b232c and b43f0e1.

Files selected for processing: 1
  • CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Added speaker diarization for 16 kHz audio, with speaker segments and tools to associate speakers with transcript word timestamps.
    • Added command-line support for running diarization with optional transcription and forced alignment.
    • Added options for model precision and execution provider, plus tools to export and validate diarization models.
  • Documentation
    • Added guidance for using, configuring, and validating diarization, including model licensing information.

Adds Nemotron diarization model export and validation tools, a C++ pipeline and CLI, and CMake integration. The CLI can combine diarization with Qwen3 transcription and forced alignment.

Changes: Nemotron diarization

Layer / File(s) Summary
ONNX export and validation
asr/diarization/model_export/*, asr/diarization/README.md, THIRD_PARTY_NOTICES.md
Adds log-mel processing and streaming model export, checkpoint-to-ONNX export, and validation against NeMo and native outputs. Documents export, validation, model behavior, and licensing.
C++ diarization runtime
asr/diarization/diarization.h, asr/diarization/diarization.cpp, asr/diarization/CMakeLists.txt, CMakeLists.txt, asr/diarization/README.md
Adds the Config, Segment, Result, and Pipeline APIs. The pipeline runs chunked inference, produces speaker segments, and supports speaker lookup by interval. Adds the library to the CMake build.
CLI and ASR alignment
asr/diarization/main.cpp, asr/diarization/CMakeLists.txt, asr/diarization/README.md
Adds a CLI for diarization with optional Qwen3 transcription and forced alignment. Aligned word timestamps include the speaker returned by Result::SpeakerAt.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~60 minutes

Merge Risk: Minimal · previous review b43f0

This change adds the diarization library to the build using the same declaration pattern the existing Whisper and Qwen3 libraries already use. Configuration is not expected to break, and no blocking issue remains in the reviewed change.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive No pull request description was provided, so the change context is not documented in the description. Add a brief description that summarizes the Nemotron-3 diarization pipeline, CLI, model export and validation tooling, and integration changes.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: adding Nemotron-3 diarization support.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot mentioned this pull request Oct 27, 2026
Base automatically changed from qwen3-asr to main October 27, 2026 15:38
Signed-off-by: contentis <luca.mspindler@gmail.com>
@contentis
contentis force-pushed the nemotron-diarization branch from 697f49d to be50dc4 Compare October 27, 2026 15:38
@contentis
contentis merged commit 99d8e0f into main Oct 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant