task: remove fschat #1567
Open
task: remove fschat #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Erick Galinkin <egalinkin@nvidia.com>
Collaborator
jmartin-tech
left a comment
jmartin-tech
left a comment
There was a problem hiding this comment.
Some static code review thoughts, runtime testing in progress.
jmartin-tech
requested changes
Jan 22, 2026
jmartin-tech
requested changes
Jan 22, 2026
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
Co-authored-by: Jeffrey Martin <jmartin@Op3n4M3.dev> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
leondz
reviewed
Jan 23, 2026
Collaborator
leondz
left a comment
leondz
left a comment
There was a problem hiding this comment.
Huge piece of work, thank you. Many questions and checks. Looking forward to landing this
…eturn the `goal_str` and `target_str` used to optimize the suffix.
Co-authored-by: Leon Derczynski <leonderczynski@gmail.com> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
Co-authored-by: Leon Derczynski <leonderczynski@gmail.com> Signed-off-by: Erick Galinkin <erick.galinkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors AutoDAN and GCG to no longer require
fschat, instead using built-in huggingface templating.Resolves #1209