Task: transformers 5 support #1582
Open
+71
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
task/transformers-5-support
branch
from
de2ea96 to
7cc3c4e
Compare
huggingface_hub version 1.0 changes the entry point from `huggingface_cli` to `hf` Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
erickgalinkin
approved these changes
Jan 29, 2026
Collaborator
erickgalinkin
left a comment
erickgalinkin
left a comment
There was a problem hiding this comment.
Looks good to me -- support merging once all tests pass.
leondz
reviewed
Jan 30, 2026
Collaborator
leondz
left a comment
leondz
left a comment
There was a problem hiding this comment.
Thanks. Good luck w/ win.
jmartin-tech
force-pushed
the
task/transformers-5-support
branch
from
cafaddf to
6b96d0a
Compare
Currently the custom generator used fails to load in windows, allow exception to be raised Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
jmartin-tech
force-pushed
the
task/transformers-5-support
branch
from
6b96d0a to
44e9a86
Compare
jmartin-tech
commented
Jan 30, 2026
Comment on lines
+43
to
+47
| if sys.platform == "win32" and klassname == "buffs.paraphrase.Fast": | ||
| # special case buff not currently supported on Windows | ||
| with pytest.raises(GarakException) as exc_info: | ||
| list(b.transform(a)) # process yield to see raise | ||
| assert "failed" in str(exc_info.value) |
Collaborator
Author
There was a problem hiding this comment.
Note this test should start to fail if/when Windows reaches a working state for this plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for transformers major version release.
Verification
List the steps needed to make sure this thing works