Add advanced health check configuration to config file#1357
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Author
|
@ArangoGutierrez 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
[WIP] Add advanced health check configuration to config file
Add advanced health check configuration to config file
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements advanced health check configuration through the config file system, allowing users to customize health monitoring behavior beyond the existing
DP_DISABLE_HEALTHCHECKSenvironment variable.New Configuration Options
The
healthsection can now be added to config files with the following options:Key Features
eventTypes: [EventTypeXidCriticalError],criticalXIDs: [48])DP_DISABLE_HEALTHCHECKSenvironment variable continues to work unchangedConfiguration Examples
NVIDIA Default (current behavior):
GKE Compatible:
Disabled Health Checks:
Implementation Details
Healthstruct toapi/config/v1package with comprehensive validationinternal/rm/health.goto use config-based settingscriticalXIDsfieldBackward Compatibility
All existing functionality remains unchanged. The
DP_DISABLE_HEALTHCHECKSenvironment variable works exactly as before, and when no health configuration is provided, the system uses the same defaults as the previous hardcoded implementation.Fixes #1340.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.