Ship static busybox shell in k8s-device-plugin image#1793
Open
rajathagasthya wants to merge 1 commit into
Open
Ship static busybox shell in k8s-device-plugin image#1793rajathagasthya wants to merge 1 commit into
rajathagasthya wants to merge 1 commit into
Conversation
rajathagasthya
force-pushed
the
add-static-shell
branch
from
3f1b45b to
1f7aa96
Compare
Flip the base from *-dev* to non-*-dev* distroless and source a static busybox from debian:trixie-slim. The device-plugin entrypoint and any shell-based lifecycle hooks continue to work via /bin/sh and busybox applet symlinks layered into the final image. Part of NVIDIA/cloud-native-team#299. Signed-off-by: Rajath Agasthya <ragasthya@nvidia.com>
rajathagasthya
force-pushed
the
add-static-shell
branch
from
1f7aa96 to
c6e0dd1
Compare
rajatchopra
reviewed
May 20, 2026
| RUN ln -s /busybox/sh /bin/sh | ||
|
|
||
| COPY --from=shell /busybox /busybox | ||
| RUN ["/busybox/ln", "-s", "/busybox/sh", "/bin/sh"] |
Contributor
There was a problem hiding this comment.
It isn't quite a departure from '-dev' if we use busybox-static. Why not bash-static?
Is it because we use extensive shell utilities?
Contributor
Author
There was a problem hiding this comment.
Yeah, the deployment manifests use shell utilities (rm, cat, etc.), which we don't get if use bash-static.
The -dev images also ship busybox in the same /busybox layout, so it's not really a departure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip the base from
*-dev*to non-*-dev*distroless and source a static busybox fromdebian:trixie-slim. The device-plugin entrypoint and any shell-based lifecycle hooks continue to work via/bin/shand busybox applet symlinks layered into the final image.Part of NVIDIA/cloud-native-team#299.
Resolves #1744.