Replace -fplan9-extensions with -fms-extensions for compiler compatibility#271
Open
vowstar wants to merge 1 commit intoNVIDIA:mainfrom
Open
Replace -fplan9-extensions with -fms-extensions for compiler compatibility#271vowstar wants to merge 1 commit intoNVIDIA:mainfrom
vowstar wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…ility To maintain compatibility with both GCC and Clang, the `-fplan9-extensions` flag is replaced with `-fms-extensions` in the Makefile. This change supports anonymous structs and unions, ensuring the same functionality across both compilers. Clang does not currently support `-fplan9-extensions`, at least there are no results yet. See also: https://reviews.llvm.org/D3853 See also: NVIDIA@162507e Bug: vowstar/vowstar-overlay#19 Signed-off-by: Huang Rui <vowstar@gmail.com>
vowstar
added a commit
to vowstar/vowstar-overlay
that referenced
this pull request
Jun 18, 2024
Upstream: NVIDIA/libnvidia-container#271 Bug: #19 Signed-off-by: Huang Rui <vowstar@gmail.com>
Author
|
ping |
4 tasks
Member
|
@klueska do you see any issues with adding this change? |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
bot
added
the
lifecycle/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maintain compatibility with both GCC and Clang, the
-fplan9-extensionsflag is replaced with-fms-extensionsin the Makefile. This change supports anonymous structs and unions, ensuring the same functionality across both compilers. Clang does not currently support-fplan9-extensions, at least there are no results yet.See also: https://reviews.llvm.org/D3853
See also: 162507e
Bug: vowstar/vowstar-overlay#19