chore(nvca): fix Deprecated doc comment formatting#230
Merged
kristinapathak merged 1 commit intoJul 21, 2026
Merged
Conversation
📝 WalkthroughWalkthroughA standalone comment separator was inserted between two mini-service metric sections in the NVCA metrics source. No logic, control flow, declarations, or metric behavior changed. ChangesMetrics formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
@mesutoezdil , can you please rebase off of main? It should fix the codeql failures. |
gocritic flagged the Deprecated notice on SetMiniServiceReadyStatus for not being in its own paragraph. Without the blank comment line, go vet and IDE tooling do not reliably recognize it as a deprecation notice, so callers would not get flagged. NO-REF Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
mesutoezdil/chore/nvca-deprecated-comment
branch
from
July 21, 2026 08:22
24f3d99 to
1a2242f
Compare
Contributor
Author
|
done, thx |
kristinapathak
enabled auto-merge
July 21, 2026 16:07
kristinapathak
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Add the blank comment line gocritic (deprecatedComment) requires before the Deprecated: notice on SetMiniServiceReadyStatus. One-line change, no behavior affected.
Issues
NO-REF