Skip to content

chore(nvca): fix Deprecated doc comment formatting#230

Merged
kristinapathak merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/chore/nvca-deprecated-comment
Jul 21, 2026
Merged

chore(nvca): fix Deprecated doc comment formatting#230
kristinapathak merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/chore/nvca-deprecated-comment

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Add the blank comment line gocritic (deprecatedComment) requires before the Deprecated: notice on SetMiniServiceReadyStatus. One-line change, no behavior affected.

Issues

NO-REF

@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 17, 2026 07:34
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A standalone comment separator was inserted between two mini-service metric sections in the NVCA metrics source. No logic, control flow, declarations, or metric behavior changed.

Changes

Metrics formatting

Layer / File(s) Summary
Comment separator
src/compute-plane-services/nvca/internal/metrics/metrics.go
Adds a standalone // line between the mini-service failure and readiness sections.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the doc comment formatting fix for the deprecated NVCA metric helper.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kristinapathak

Copy link
Copy Markdown
Contributor

@mesutoezdil , can you please rebase off of main? It should fix the codeql failures.

gocritic flagged the Deprecated notice on SetMiniServiceReadyStatus
for not being in its own paragraph. Without the blank comment line,
go vet and IDE tooling do not reliably recognize it as a deprecation
notice, so callers would not get flagged.

NO-REF

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the mesutoezdil/chore/nvca-deprecated-comment branch from 24f3d99 to 1a2242f Compare July 21, 2026 08:22
@mesutoezdil

Copy link
Copy Markdown
Contributor Author

done, thx

@kristinapathak
kristinapathak enabled auto-merge July 21, 2026 16:07
@kristinapathak
kristinapathak added this pull request to the merge queue Jul 21, 2026
Merged via the queue into NVIDIA:main with commit 94f0263 Jul 21, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants