fix(worker): add missing go.sum entries, restore clean build#232
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@mesutoezdil , can you please rebase off of main? It should fix the codeql failures. |
go.sum was missing the go.mod hash lines for klauspost/compress v1.18.5 and pelletier/go-toml/v2 v2.3.0 (only the module hash was present for each). go build ./... fails outright with "missing go.sum entry for go.mod file" on any checkout that does not already have these modules warm in the local module cache, which includes a clean CI runner. Added both with go mod download; no go.mod change. Verified with go build, go vet, and go test ./... (all packages pass). NO-REF Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
ba081f8 to
10b1a26
Compare
|
done, thx |
3 participants
TL;DR
src/libraries/go/worker/go.sum was missing the go.mod hash lines for two transitive deps, so go build failed without a warm module cache. Only go.sum changed. go build, go vet, go test pass for every package.
Issues
NO-REF