Skip to content

docs(agents): note imports.yaml is internal, fix stale helmfile ref#258

Merged
kristinapathak merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/docs/imports-yaml-internal-note
Jul 21, 2026
Merged

docs(agents): note imports.yaml is internal, fix stale helmfile ref#258
kristinapathak merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/docs/imports-yaml-internal-note

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

imports.yaml is referenced in root AGENTS.md but does not exist in this public snapshot, same as tools/ci/subproject-validations.yaml (see #213). Noted that next to its first mention.

Also two skill docs listed a 000-prepare.yaml.gotmpl file in the self-managed helmfile.d layout that was never there; only 01-dependencies, 02-core, and 03-observability exist. Removed the stale line and regenerated skilldata_generated.go.

Tested: grep confirms no remaining 000-prepare references anywhere in the repo. go generate ./internal/agentskill/... run and committed.

Refs: NO-REF

Summary by CodeRabbit

  • Documentation
    • Clarified that imports.yaml is an internal file and may not appear in the public snapshot.
    • Updated stack documentation to reflect the current authoritative Helmfile sources.
    • Corrected the self-managed installation directory reference by removing an outdated preparation file entry.

imports.yaml does not exist in this public snapshot, same as
tools/ci/subproject-validations.yaml. Noted that next to its first
mention in root AGENTS.md.

Also removed a 000-prepare.yaml.gotmpl reference from two skill docs;
that file was never part of the self-managed helmfile.d layout, only
01-dependencies, 02-core, and 03-observability are. Regenerated
skilldata_generated.go for the doc change.

JIRA: NO-REF
NVBug: none
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 20, 2026 13:01
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 270d8d34-bb8a-4b66-817f-ab73c2ead7a3

📥 Commits

Reviewing files that changed from the base of the PR and between adfbbd8 and a2dee0a.

⛔ Files ignored due to path filters (1)
  • src/clis/nvcf-cli/internal/agentskill/skilldata_generated.go is excluded by !**/*_generated.go
📒 Files selected for processing (3)
  • AGENTS.md
  • ai-tooling/dev/skills/nvcf-explore-stack/SKILL.md
  • ai-tooling/user/skills/nvcf-self-managed-installation/references/helmfile-structure.md
💤 Files with no reviewable changes (2)
  • ai-tooling/user/skills/nvcf-self-managed-installation/references/helmfile-structure.md
  • ai-tooling/dev/skills/nvcf-explore-stack/SKILL.md

📝 Walkthrough

Walkthrough

Changes

Documentation reference alignment

Layer / File(s) Summary
Align documentation references
AGENTS.md, ai-tooling/dev/skills/nvcf-explore-stack/SKILL.md, ai-tooling/user/skills/nvcf-self-managed-installation/references/helmfile-structure.md
Clarifies that imports.yaml is absent from the public snapshot and removes stale 000-prepare.yaml.gotmpl references from helmfile documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/nvcf#244: Updates the same stack exploration skill documentation by removing another obsolete reference.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly captures the doc note about imports.yaml and the stale helmfile reference cleanup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🛡️ CodeQL Analysis

🚨 Found 4 issue(s)

Severity Breakdown:

  • 🔴 Errors: 0
  • 🟡 Warnings: 0
  • 🔵 Notes: 0
📋 Top Issues

🔗 View full details in Security tab

🕐 Last updated: 2026-07-21 06:09:15 UTC | Commit: a2dee0a

@kristinapathak
kristinapathak added this pull request to the merge queue Jul 21, 2026
Merged via the queue into NVIDIA:main with commit c292aa9 Jul 21, 2026
17 checks passed
@balajinvda

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version nvcf-cli-v1.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants