Skip to content

fix(nvcf-self-managed-cli): add NVCT trigger keywords and task delete guardrail#288

Open
shelleyshen-0 wants to merge 1 commit into
mainfrom
fix/nvct-skill-trigger-and-task-delete-guardrail
Open

fix(nvcf-self-managed-cli): add NVCT trigger keywords and task delete guardrail#288
shelleyshen-0 wants to merge 1 commit into
mainfrom
fix/nvct-skill-trigger-and-task-delete-guardrail

Conversation

@shelleyshen-0

@shelleyshen-0 shelleyshen-0 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Add NVCT trigger keywords to nvcf-self-managed-cli so "NVCT task" prompts reliably activate the skill, and add task delete to the Safety rules block so the confirm-before-delete requirement is enforced on standalone delete requests.

Additional Details

Two issues drove this change:

  1. "NVCT" was absent from the skill's trigger keyword list. On bare "NVCT task" phrasing the agent would misroute or handle the request without the skill — including falsely claiming a task was already deleted without ever calling nvcf-cli.

  2. nvcf-cli task delete was missing from the Safety rules "never without confirmation" block. The confirm-before-delete rule in prompts/create-and-run-task.md is only loaded for the create-and-run-task workflow; a standalone delete request reads only SKILL.md, where there was no safety rule for task delete.

Changes:

  • Added NVCT, NVCT task, NVCT batch job to the frontmatter description trigger keyword list
  • Collapsed five task-related "When to use" bullets into two (one generic, one NVCT-specific)
  • Added a "When to use" bullet explicitly covering NVCT task phrasing
  • Added nvcf-cli task delete to the Safety rules block alongside function delete and cluster delete
  • Regenerated skilldata_generated.go

For the Reviewer

ai-tooling/user/skills/nvcf-self-managed-cli/SKILL.md is the only hand-edited file; src/clis/nvcf-cli/internal/agentskill/skilldata_generated.go is auto-generated from it via go generate ./internal/agentskill/....

For QA

Skill trigger and safety rule changes are verified by reading the updated SKILL.md. CI check-agent-skill-generated verifies skilldata_generated.go is not stale.

Issues

nvbugs/6465208
nvbugs/6465985

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

… guardrail

- Add NVCT, NVCT task, NVCT batch job to frontmatter description trigger list
- Collapse redundant NVCT sub-keywords in description
- Add NVCT bullet to "When to use" section covering list/run/cancel/delete/results
- Collapse five task-related "When to use" bullets into two
- Add nvcf-cli task delete to Safety rules alongside function delete and cluster delete
@shelleyshen-0
shelleyshen-0 requested a review from a team as a code owner July 21, 2026 06:39
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updated the self-managed CLI skill documentation with broader task-related triggers and usage guidance, service URL references, and an explicit warning that task deletion permanently removes the task record.

Changes

CLI skill guidance

Layer / File(s) Summary
Task discovery and safety guidance
ai-tooling/user/skills/nvcf-self-managed-cli/SKILL.md
Expanded trigger keywords and “When to use” coverage for task operations, NVCT batches, and related services; documented permanent deletion by nvcf-cli task delete.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: new NVCT trigger keywords and the task delete safety guardrail.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nvct-skill-trigger-and-task-delete-guardrail

Comment @coderabbitai help to get the list of available commands.

@kristinapathak

Copy link
Copy Markdown
Contributor

Please add a github issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants