fix(nvcf-self-managed-cli): add NVCT trigger keywords and task delete guardrail#288
Open
shelleyshen-0 wants to merge 1 commit into
Open
fix(nvcf-self-managed-cli): add NVCT trigger keywords and task delete guardrail#288shelleyshen-0 wants to merge 1 commit into
shelleyshen-0 wants to merge 1 commit into
Conversation
… guardrail - Add NVCT, NVCT task, NVCT batch job to frontmatter description trigger list - Collapse redundant NVCT sub-keywords in description - Add NVCT bullet to "When to use" section covering list/run/cancel/delete/results - Collapse five task-related "When to use" bullets into two - Add nvcf-cli task delete to Safety rules alongside function delete and cluster delete
📝 WalkthroughWalkthroughUpdated the self-managed CLI skill documentation with broader task-related triggers and usage guidance, service URL references, and an explicit warning that task deletion permanently removes the task record. ChangesCLI skill guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
sbaum1994
approved these changes
Jul 21, 2026
Contributor
|
Please add a github issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Add NVCT trigger keywords to
nvcf-self-managed-cliso "NVCT task" prompts reliably activate the skill, and addtask deleteto the Safety rules block so the confirm-before-delete requirement is enforced on standalone delete requests.Additional Details
Two issues drove this change:
"NVCT" was absent from the skill's trigger keyword list. On bare "NVCT task" phrasing the agent would misroute or handle the request without the skill — including falsely claiming a task was already deleted without ever calling nvcf-cli.
nvcf-cli task deletewas missing from the Safety rules "never without confirmation" block. The confirm-before-delete rule inprompts/create-and-run-task.mdis only loaded for the create-and-run-task workflow; a standalone delete request reads only SKILL.md, where there was no safety rule for task delete.Changes:
NVCT,NVCT task,NVCT batch jobto the frontmatterdescriptiontrigger keyword listnvcf-cli task deleteto the Safety rules block alongsidefunction deleteandcluster deleteskilldata_generated.goFor the Reviewer
ai-tooling/user/skills/nvcf-self-managed-cli/SKILL.mdis the only hand-edited file;src/clis/nvcf-cli/internal/agentskill/skilldata_generated.gois auto-generated from it viago generate ./internal/agentskill/....For QA
Skill trigger and safety rule changes are verified by reading the updated SKILL.md. CI
check-agent-skill-generatedverifiesskilldata_generated.gois not stale.Issues
nvbugs/6465208
nvbugs/6465985
Checklist