fix(openbao-migrations): sleep between health check retries

[mesutoezdil]

TL;DR

The OpenBao health check loop logged "Retrying in 5 seconds" but never slept, so all 5 attempts ran within milliseconds and slow startups failed the migration Job. Adds the missing sleep. bash -n passes; entrypoint script with no test harness.

Issues

Closes #293

Summary by CodeRabbit

• Bug Fixes
  • Added an explicit wait between OpenBao /v1/sys/health retry attempts.
  • Updated migration warning text formatting when failures are permitted, while keeping the same migration outcomes and exit behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9581821f-2a55-4876-8789-fa685bb72995

📥 Commits

Reviewing files that changed from the base of the PR and between 1bab501 and 96d97f4.

📒 Files selected for processing (1)

• migrations/openbao/entrypoint.sh

🚧 Files skipped from review as they are similar to previous changes (1)

• migrations/openbao/entrypoint.sh

---

📝 Walkthrough

Walkthrough

The OpenBao migration entrypoint now pauses between failed health-check attempts. It also clarifies migration failure comments and updates the warning emitted when failures are allowed.

Changes

OpenBao migration handling

Layer / File(s)	Summary
Retry and failure handling migrations/openbao/entrypoint.sh	Adds the configured retry delay to the health-check loop, clarifies downstream failure comments, and updates the allowed-failure warning wording.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: max-nv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows Conventional Commits and accurately describes the main fix in the diff.
Linked Issues check	✅ Passed	The added sleep directly addresses issue #293 by spacing out OpenBao health check retries.
Out of Scope Changes check	✅ Passed	The remaining edits are minor wording/comment tweaks in the same migration script and stay within scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@migrations/openbao/entrypoint.sh`:
- Line 66: Add shell-level coverage for the retry loop surrounding the sleep
command in the entrypoint script, verifying that consecutive failed health
checks are separated by RETRY_DELAY; use the repository-native test runner to
execute it before committing, or document in the PR why such timing coverage is
infeasible.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 33fc496a-2240-418e-8aaf-6eef4d9a8737

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef95ed and fab42f0.

📒 Files selected for processing (1)

• migrations/openbao/entrypoint.sh