fix(nvcf-unbound): nest format param under params in PodMonitor#296
Merged
balajinvda merged 1 commit intoJul 21, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PodMonitor configuration now nests ChangesPodMonitor scrape configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The logger-metrics endpoint wrote format: at the same level as params:, so params rendered null and the unknown top-level format field was pruned by the CRD schema. The format=prometheus query parameter was never sent to the scrape endpoint. Indent it under params like the container-cache chart does. Closes NVIDIA#295 Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
mesutoezdil/fix/nvcf-unbound-podmonitor-params
branch
from
July 21, 2026 17:51
845c594 to
dcf5ead
Compare
balajinvda
approved these changes
Jul 21, 2026
balajinvda
left a comment
Contributor
There was a problem hiding this comment.
LGTM — correct fix: format nested under params so the PodMonitor scrape param isn't schema-pruned. Matches the container-cache chart. CI green.
balajinvda
enabled auto-merge
July 21, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
In the logger-metrics endpoint, format: sat at the same indent level as params:, so the CRD schema pruned it and the format=prometheus scrape parameter was never sent. Nested it under params, matching the container-cache chart. helm lint and helm template verified.
Issues
Closes #295
Summary by CodeRabbit