Skip to content

fix(nvcf-unbound): nest format param under params in PodMonitor#296

Merged
balajinvda merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/fix/nvcf-unbound-podmonitor-params
Jul 21, 2026
Merged

fix(nvcf-unbound): nest format param under params in PodMonitor#296
balajinvda merged 1 commit into
NVIDIA:mainfrom
mesutoezdil:mesutoezdil/fix/nvcf-unbound-podmonitor-params

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

TL;DR

In the logger-metrics endpoint, format: sat at the same indent level as params:, so the CRD schema pruned it and the format=prometheus scrape parameter was never sent. Nested it under params, matching the container-cache chart. helm lint and helm template verified.

Issues

Closes #295

Summary by CodeRabbit

  • Bug Fixes
    • Corrected Prometheus metrics configuration to ensure monitoring endpoints are interpreted properly.

@mesutoezdil
mesutoezdil requested a review from a team as a code owner July 21, 2026 09:15
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 556c2fd7-189a-4652-b1ce-5c0fc64f9899

📥 Commits

Reviewing files that changed from the base of the PR and between 845c594 and dcf5ead.

📒 Files selected for processing (1)
  • deploy/helm/nvcf-unbound/templates/podmonitor.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • deploy/helm/nvcf-unbound/templates/podmonitor.yaml

📝 Walkthrough

Walkthrough

The PodMonitor configuration now nests format: [prometheus] under params: for the first metrics endpoint.

Changes

PodMonitor scrape configuration

Layer / File(s) Summary
Nest format under endpoint parameters
deploy/helm/nvcf-unbound/templates/podmonitor.yaml
Moves the Prometheus format setting from the endpoint level into the params: block.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: balajinvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main PodMonitor fix and matches the change set.
Linked Issues check ✅ Passed The change nests format under params as required by issue #295, restoring the intended query parameter.
Out of Scope Changes check ✅ Passed The PR only changes the PodMonitor nesting and introduces no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

The logger-metrics endpoint wrote format: at the same level as
params:, so params rendered null and the unknown top-level format
field was pruned by the CRD schema. The format=prometheus query
parameter was never sent to the scrape endpoint. Indent it under
params like the container-cache chart does.

Closes NVIDIA#295

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the mesutoezdil/fix/nvcf-unbound-podmonitor-params branch from 845c594 to dcf5ead Compare July 21, 2026 17:51

@balajinvda balajinvda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — correct fix: format nested under params so the PodMonitor scrape param isn't schema-pruned. Matches the container-cache chart. CI green.

@balajinvda
balajinvda enabled auto-merge July 21, 2026 18:12
@balajinvda
balajinvda added this pull request to the merge queue Jul 21, 2026
Merged via the queue into NVIDIA:main with commit 4a877f4 Jul 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nvcf-unbound: PodMonitor format param not nested under params

2 participants