fix: ensure systemd service is restarted if nvidia-smi fails#1836
Merged
Conversation
We run nvidia-smi in an ExecStart statement instead of an ExecCondition statement so that the unit gets restarted in case of failures. With ExecCondition, if the command returns an error code between 1 and 254 (inclusive) the remaining commands are skipped and the unit is not marked as failed, and thus the service is not restarted. Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Contributor
Author
|
/cherry-pick release-1.19 |
tariq1890
approved these changes
May 19, 2026
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run nvidia-smi in an ExecStart statement instead of an ExecCondition statement so that the unit gets restarted in case of failures. With ExecCondition, if the command returns an error code between 1 and 254 (inclusive) the remaining commands are skipped and the unit is not marked as failed, and thus the service is not restarted.