fix(harness): preserve per-service test accounting on timeout#43
Open
innocentmchry wants to merge 1 commit into
Open
fix(harness): preserve per-service test accounting on timeout#43innocentmchry wants to merge 1 commit into
innocentmchry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a harness container timed out, timeout handling could propagate a non-usable status into aggregation.
That could short-circuit to a single fallback failure for the whole datapoint, dropping other service-level
results from accounting. In multi-service cases this undercounted total tests (often removing passes) and
skewed the final pass rate.
This makes reporting consistent: each service contributes one test result, timed-out services are failed,
and total/passed/failed numbers reflect all executed service outcomes.