Temporary work around for card collapse issue on Android #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some weird stuff going on with the
Collapsiblecomponent fromreact-native-collapsibleand it not rendering correctly on Android. There was a patch fix that was applied, but, for some reason, it doesn't work when the view that has theCollapsedCardcomponent is shown as a part of the top tab navigator that's on theForecastScreen.Specifically, it fails to render correctly when the card is a part of a view that is not the initial screen for the tab navigator.
This work around makes it so that the cards are collapsed on Android by default for the cards that are in the
WeatherTab. TheAvalancheTabdoesn't have this issue because it's the initial screen. This is not a permanent fix as the issue is fixed with the New Architecture enabled