-
Notifications
You must be signed in to change notification settings - Fork 1
Improve and simplify wrapInContainer behavior with background color picker
#899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wrapInContainerwrapInContainer behavior with background color picker
|
Preview deployment: https://improve-bg-color-picker.preview.avy-fx.org |
Migration Safety CheckFound 28 potential issues: 20260131_012456_remove_wrap_in_container.ts Warning (line 6): ALTER keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_header_block\` ADD \`full_width_color\` integer DEFAULT true;`,Warning (line 12): DROP keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 12): ALTER keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 15): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_header_block\` ADD \`full_width_color\` integer DEFAULT true;`,Warning (line 21): DROP keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 21): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 24): ALTER keyword detected - review for data loss sql`ALTER TABLE \`pages_blocks_header_block\` ADD \`full_width_color\` integer DEFAULT true;`,Warning (line 29): DROP keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 29): ALTER keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 31): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_pages_v_blocks_header_block\` ADD \`full_width_color\` integer DEFAULT true;`,Warning (line 36): DROP keyword detected - review for data loss await db.run(sql`ALTER TABLE \`_pages_v_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 36): ALTER keyword detected - review for data loss await db.run(sql`ALTER TABLE \`_pages_v_blocks_header_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 38): DROP keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 38): ALTER keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 41): DROP keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 41): ALTER keyword detected - review for data loss sql`ALTER TABLE \`home_pages_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 44): DROP keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 44): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 47): DROP keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 47): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_home_pages_v_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 49): DROP keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 49): ALTER keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 50): DROP keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 50): ALTER keyword detected - review for data loss await db.run(sql`ALTER TABLE \`pages_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`)Warning (line 52): DROP keyword detected - review for data loss sql`ALTER TABLE \`_pages_v_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 52): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_pages_v_blocks_document_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 55): DROP keyword detected - review for data loss sql`ALTER TABLE \`_pages_v_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Warning (line 55): ALTER keyword detected - review for data loss sql`ALTER TABLE \`_pages_v_blocks_sponsors_block\` DROP COLUMN \`wrap_in_container\`;`,Review these patterns and add backup/restore logic if needed. See |
Description
The previous background color controls and the
wrapInContaineroption created a confusing experience:wrapInContainercould be set regardless of the chosen background color and its meaning was not obvious.wrapInContainerwas also used to handle 2 different container scenarios:backgroundColorbackgroundColorvisibleThese should be handled based on the rendering context (standalone vs Lexical).
This change:
wrapInContainertoisLexicalfor clearer intentisLexical={false}(standalone blocks)isLexical={true}(Lexical blocks)Related Issues
Fixes #654
Key Changes
wrapInContainerprop toisLexicalthroughout codebaseRenderBlocks.tsx) →isLexical={false}RichText/index.tsx) →isLexical={true}__Blockand__LexicalBlockconfig options (excludingHeader)How to test
Adding effected blocks from a separate branch and this branch to compare the visual difference
Screenshots / Demo video
wrapInContainervisible in admin UI with unclear purposeMigration Explanation
wrap_in_container. Addfull_width_colorforheaderBlockFuture enhancements / Questions