Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a08bc18 to
12e6c9c
Compare
8db0d09 to
a319499
Compare
6aba443 to
cb3213a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1839
all builds on this branch
dev vs prod
HTML map of a correct dev example attached to this github comment
row counts:
row order within groups with the same
generic_segmentid:values:
to_/from_nodeid_valuesnew qa approach
added and using the
dbt-audit-helperdbt package in the new qa rpl modelsthe models uses the
compare_and_classify_query_resultsmacro to generate a row-by-row comparison and summary stats of added, removed, identical and modified records(in-progress description) to qa record ordering, I had to add a
rpl_idto each table (query) to incorporate row order into the key for comparison. by default, there are max of 20 sample records per "status"summary of results from
qa__rpl_order:notes
Checking ordering within groups of 5 roadbed records surfaced a bug that is now resolved and those groups appear to have the right ordering now.
The bug in some of the large groups was caused by the logic assuming that an innermost segment would be closer to it's side's outermost segment than that of the other side. So if an innermost segment on the right side was so close to the central generic that the distance to the outermost left is less than the distance to the outermost right, then the ordering was incorrect because the logic presumed it was to the left of the central generic.