Skip to content

add Roadbed Pointer List#2262

Open
damonmcc wants to merge 6 commits intomainfrom
fvk-rpl
Open

add Roadbed Pointer List#2262
damonmcc wants to merge 6 commits intomainfrom
fvk-rpl

Conversation

@damonmcc
Copy link
Member

@damonmcc damonmcc commented Mar 3, 2026

resolves #1839

all builds on this branch

dev vs prod

HTML map of a correct dev example attached to this github comment

row counts:

  • 10 more rows in dev (29,181 vs 29,171)
  • 29 rows in dev that aren't in prod
  • 19 rows in prod that aren't in dev

row order within groups with the same generic_segmentid:

  • 278 diffs in row ordering
  • apparent causes (still reviewing):
    • wrong order in prod (e.g. L roadbed before R)
    • source records not having an R roadbed in their group

values:

  • 3 diffs in values
  • all related to to_/from_ nodeid_ values

new qa approach

added and using the dbt-audit-helper dbt package in the new qa rpl models

the models uses the compare_and_classify_query_results macro to generate a row-by-row comparison and summary stats of added, removed, identical and modified records

(in-progress description) to qa record ordering, I had to add a rpl_id to each table (query) to incorporate row order into the key for comparison. by default, there are max of 20 sample records per "status"

summary of results from qa__rpl_order:

dbt_audit_row_status dbt_audit_num_rows_in_status
added 29
identical 28874
modified 278
removed 19

notes

Checking ordering within groups of 5 roadbed records surfaced a bug that is now resolved and those groups appear to have the right ordering now.

The bug in some of the large groups was caused by the logic assuming that an innermost segment would be closer to it's side's outermost segment than that of the other side. So if an innermost segment on the right side was so close to the central generic that the distance to the outermost left is less than the distance to the outermost right, then the ordering was incorrect because the logic presumed it was to the left of the central generic.

@damonmcc damonmcc changed the title add rpl formatting seed and recipe entry add Roadbed Pointer List Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.70%. Comparing base (fef4e7f) to head (1964f9d).

Additional details and impacted files
Files with missing lines Coverage Δ
dcpy/__main__.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@damonmcc damonmcc force-pushed the fvk-rpl branch 3 times, most recently from a08bc18 to 12e6c9c Compare March 4, 2026 21:54
@damonmcc damonmcc force-pushed the fvk-rpl branch 3 times, most recently from 8db0d09 to a319499 Compare March 6, 2026 21:10
@damonmcc damonmcc marked this pull request as ready for review March 6, 2026 21:38
@damonmcc damonmcc requested a review from alexrichey March 6, 2026 21:39
@damonmcc damonmcc force-pushed the fvk-rpl branch 2 times, most recently from 6aba443 to cb3213a Compare March 8, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Roadbed Pointer List

2 participants