Repository navigation
action: a manifest GitHub can actually parse - #35
Merged
Merged
Conversation
Every workflow using Na5co/polygo/action@v0 failed at "Set up job" with a YAML error before polygo ran: an input description held an unquoted `(default: all targets in polygo.toml)`, and YAML reads `: ` in a plain scalar as a mapping. Nothing loaded the manifest — the tests run the scripts, and polygo's own CI has no use for the Action — so it went unnoticed. Found by pointing the Action at a real pull request. Two guards: a test that lints every plain scalar in the manifest for the same trap (it fails on the exact line that shipped), and a CI job that uses the Action from the checkout on a fixture with a broken placeholder and asserts it fails with one error. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointing the Action at a real pull request (the first time anything ever loaded its manifest) produced this, before polygo ran at all:
Line 26 was an input description holding an unquoted
(default: all targets in polygo.toml). YAML reads:in a plain scalar as a mapping, so the whole manifest failed to load — every workflow usingNa5co/polygo/action@v0failed at "Set up job". It predates the review work; nothing ever loaded the file, becausetests/action.rsruns the scripts and polygo's own CI has no use for the Action.One character class of fix, two guards so it cannot come back:
action_manifest_is_loadable_yamllints every plain scalar in the manifest for the same trap. Verified against the broken file: it fails, naming line 26.uses: ./action) on a fixture with a translated placeholder name, asserting the step fails and reports exactly one error. That loads the manifest and runscheck.shfor real, which the unit tests cannot do.tests/release_layout.rsasserts that job stays in CI.🤖 Generated with Claude Code