Repository navigation
check: a finding about a file sits on line 1, so a review can carry it - #40
Merged
Merged
Conversation
A review can only comment on a line. A `locale` warning — and a `syntax` error whose parser gave no position — had no line, so the reviewer dropped it: the bot reported a pull request that adds an unlisted locale as clean, which is exactly the silence the locale check was added to end. Found by asking the reviewer what it would post before pushing a pull request at the live bot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught by testing the new
localecheck through the reviewer rather than only throughcheck.A review comment must be attached to a line.
localehad no line — it is about the file — socheck --reviewdropped it as unplaceable and, with nothing left to say, posted nothing at all. A pull request adding an unlisted locale would still have come back clean from the bot: the precise silence thelocalecode was added to end, moved one layer out.File-level findings now sit on line 1: the
localewarning, and asyntaxerror whose parser reported no position. For a newly added file line 1 is in the diff, so the comment lands at the top of the file; for an untouched file it stays out of the review, as it should.Corpus fingerprint unchanged, workspace green, and a test that runs the whole path: an unlisted locale file, the diff that adds it, and a review carrying the comment on line 1.
🤖 Generated with Claude Code