Skip to content

Made CallbackGame model serializable#128

Open
kvokov wants to merge 2 commits into
Naltox:masterfrom
kvokov:master
Open

Made CallbackGame model serializable#128
kvokov wants to merge 2 commits into
Naltox:masterfrom
kvokov:master

Conversation

@kvokov

@kvokov kvokov commented Oct 5, 2016

Copy link
Copy Markdown

Also please add export of CallbackGame in Models.js file, it's missing now.

@Naltox

Naltox commented Oct 6, 2016

Copy link
Copy Markdown
Owner

Hey, i dont think there is a reason to make it serializable because its just a placeholder

@kvokov

kvokov commented Oct 6, 2016

Copy link
Copy Markdown
Author

Just because I wanna do the things like

let keyboard = new InlineKeyboardMarkup([[
    new InlineKeyboardButton('Play Game', null, null, null, null, new CallbackGame())
]]);
scope.api.sendGame(scope.chatId, config.gameShortName, {
    reply_markup: JSON.stringify(keyboard.toJSON())
})

@kvokov

kvokov commented Oct 6, 2016

Copy link
Copy Markdown
Author

I'm pretty sure that all models should have such methods, so will be cool to extend some BaseModel or add mixins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants