Wire deploy optimization, add configurable friendbot/faucet support, and use dynamic Horizon URLs#144
Merged
Merged
Conversation
…upport, and use dynamic Horizon URLs
|
@Johnsmichael150 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances StarForge network portability and deploy tooling by adding configurable friendbot/faucet support, removing hardcoded Horizon faucet URLs, and wiring Soroban WASM optimization into the deploy pipeline.
Changes
friendbot_urltoNetworkConfignetwork add --friendbot-urlsrc/utils/horizon.rsto resolve Horizon endpoints dynamicallydeploy --optimizesupport insrc/commands/deploy.rsFiles changed
src/utils/config.rssrc/utils/horizon.rssrc/commands/deploy.rssrc/commands/network.rssrc/commands/wallet.rsCargo.lockTesting
cargo run -- network add customnet --friendbot-url https://faucet.example.comcargo run -- wallet fund --network customnetcargo run -- deploy --optimize <args>Close #111
Close #103
Close #125
Close #110