Quality: Unconditional worktree mode enabled#278
Open
tuanaiseo wants to merge 1 commit intoNanmiCoder:mainfrom
Open
Quality: Unconditional worktree mode enabled#278tuanaiseo wants to merge 1 commit intoNanmiCoder:mainfrom
tuanaiseo wants to merge 1 commit intoNanmiCoder:mainfrom
Conversation
The isWorktreeModeEnabled function always returns true unconditionally. The comment mentions it was previously gated by a GrowthBook flag but the implementation is now a simple constant return. Affected files: worktreeModeEnabled.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
dosubot
Bot
added
the
size:XS
PR quality triageChanged areas: area:cli-core CLI core policy: Blocked by policy until a maintainer applies CLI core files:
Expected checks:
Test coverage signals:
Risk notes:
Hard merge gates still come from GitHub Actions, not AI review. Dosu handoff: Dosu can be used as the AI reviewer for risk explanation, missing-test prompts, and maintainer Q&A. If it does not comment automatically from the PR template, ask: @dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The isWorktreeModeEnabled function always returns true unconditionally. The comment mentions it was previously gated by a GrowthBook flag but the implementation is now a simple constant return.
Severity:
mediumFile:
src/utils/worktreeModeEnabled.tsSolution
If this is intentionally always enabled, consider using a constant instead of a function. If conditional behavior is needed, implement the proper feature flag logic.
Changes
src/utils/worktreeModeEnabled.ts(modified)Testing