Skip to content

feat(feishu): support single-locale post content + add commit helper …#317

Open
burnlife001 wants to merge 1 commit intoNanmiCoder:mainfrom
burnlife001:freature/burnlife001
Open

feat(feishu): support single-locale post content + add commit helper …#317
burnlife001 wants to merge 1 commit intoNanmiCoder:mainfrom
burnlife001:freature/burnlife001

Conversation

@burnlife001
Copy link
Copy Markdown

…scripts

  • Handle Feishu post messages with flat content structure (fallback to parsed.content)

  • add __cc-haha-op.sh for easy devops

  • Add cross-platform commit helpers (bash/ps1) for LLM-generated messages

Summary

Verification

  • I ran the relevant local checks, or explained why they do not apply.

Risk

  • This PR does not touch CLI core paths, or it has maintainer approval for allow-cli-core-change.
  • User-facing behavior changes include tests or an explanation of why tests are not practical.

@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.

…scripts

- Handle Feishu post messages with flat content structure (fallback to parsed.content)

- add __cc-haha-op.sh for easy devops
- Add cross-platform commit helpers (bash/ps1) for LLM-generated messages
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR quality triage

Changed areas: area:adapters

CLI core policy: No CLI-core policy block detected.

CLI core files:

  • none

Expected checks:

  • change-policy
  • adapter-checks
  • desktop-native-checks

Test coverage signals:

  • Adapter product files changed without an adapter test file in the PR.

Risk notes:

  • No special risk notes from changed paths.

Hard merge gates still come from GitHub Actions, not AI review.

Dosu handoff: Dosu can be used as the AI reviewer for risk explanation, missing-test prompts, and maintainer Q&A. If it does not comment automatically from the PR template, ask:

@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.

@dosubot dosubot Bot added the enhancement New feature or request label May 8, 2026
@dosubot
Copy link
Copy Markdown

dosubot Bot commented May 8, 2026

Here's my review of PR #317 across the requested risk areas:

Overall Risk: LOW


CLI Core Impact: None
This PR does not touch any CLI core paths — no changes to entry points (bin/claude-haha, src/entrypoints/cli.tsx), command handlers, CLI I/O infrastructure, or transport layers [1]. All new files are developer tooling scripts in root/zbak_script/ directories.

Desktop Startup Risk: Negligible
The only runtime code change is in adapters/feishu/extract-payload.ts, which is a backward-compatible fallback addition (parsed.zh_cn?.content ?? parsed.en_us?.content ?? parsed.content ?? []). No Tauri main process, React frontend, or sidecar launch logic is touched.

Changed-Area Risk:

  • Shell scripts (914 new lines): Isolated developer tooling — won't affect runtime. However, cross-platform routing (bash ↔ PowerShell) is untested and could have compatibility issues on edge-case environments. ⚠️
  • Feishu adapter (3 additions, 1 deletion): Additive-only change. Handles single-locale post content as a fallback without removing existing multi-locale parsing. Low risk.

Missing Tests: Medium concern ⚠️

  • No tests added for new shell/PowerShell scripts (harder to unit test, but basic syntax validation would help)
  • No tests added/updated for the Feishu adapter fallback logic
  • Recommend verifying existing Feishu adapter tests still pass and consider adding a case for the single-locale parsed.content path

Docs Impact: Gap 📝

  • No README or developer documentation updates for the new scripts (___git_commit_push_llm.sh, __cc-haha-op.sh)
  • New tooling would benefit from at minimum a usage section in the project README

Recommendations:

  1. Verify desktop/scripts/build-windows-x64.ps1 exists (referenced by __cc-haha-op.sh build-exe command)
  2. Add/run Feishu adapter tests covering the single-locale content path
  3. Test the PowerShell script on Windows with both pwsh and powershell
  4. Consider documenting the new developer scripts

To reply, just mention @dosu.


Docs are dead. Just use Dosu.

Leave Feedback Ask Dosu about cc-haha Share Dosu with your team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:adapters enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant