Skip to content

Add flux member function for class dft_near2far in C++ and DftNear2Far in Python#2670

Draft
oskooi wants to merge 1 commit into
NanoComp:masterfrom
oskooi:n2f_flux
Draft

Add flux member function for class dft_near2far in C++ and DftNear2Far in Python#2670
oskooi wants to merge 1 commit into
NanoComp:masterfrom
oskooi:n2f_flux

Conversation

@oskooi

@oskooi oskooi commented Oct 8, 2023

Copy link
Copy Markdown
Collaborator

Fixes #2665.

Requires a (working) SWIG wrapper and a unit test.

@codecov-commenter

codecov-commenter commented Oct 8, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.81%. Comparing base (e908ef8) to head (1cf5550).
⚠️ Report is 188 commits behind head on master.

Files with missing lines Patch % Lines
python/simulation.py 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
- Coverage   73.81%   73.81%   -0.01%     
==========================================
  Files          18       18              
  Lines        5294     5296       +2     
==========================================
+ Hits         3908     3909       +1     
- Misses       1386     1387       +1     
Files with missing lines Coverage Δ
python/simulation.py 77.04% <50.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oskooi

oskooi commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator Author

Turns out this feature is more challenging to implement than I originally thought because add_near2far does not center its DFT fields on the Yee-grid voxels unlike add_flux (see #2538 (comment) for more details). This is why the Poynting flux calculation in add_flux is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DftNear2Far class contains no member function to compute Poynting flux of its near/monitor fields

2 participants