Bioc build failure - #43
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change resolves the S4 signature mismatch while preserving existing behavior.
Pull request overview
Fixes Bioconductor package loading by aligning the transform S4 method with its generic.
Changes:
- Renames the method’s first argument to
xand updates references. - Advances the package version to
1.21.1.
File summaries
| File | Description |
|---|---|
R/NanoStringRccSet-utils.R |
Corrects the transform method signature. |
DESCRIPTION |
Updates the package version. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a package build failure caused by the
transformS4 method forNanoStringRccSetusing_dataas its first formal argument.BiocGenericsdefinestransformwith an S4 dispatch signature based onx. During namespace loading, the mismatched method definition triggeredconformMethod()and preventedNanoStringNCToolsfrom being installed.The method now:
xas its first formal argument._datatox.https://bioconductor.org/checkResults/devel/bioc-LATEST/NanoStringNCTools/nebbiolo2-install.html