Fix removing to much when creating a dotted attribute key#16
Open
gisostallenberg wants to merge 1 commit intoNaoray:mainfrom
Open
Fix removing to much when creating a dotted attribute key#16gisostallenberg wants to merge 1 commit intoNaoray:mainfrom
gisostallenberg wants to merge 1 commit intoNaoray:mainfrom
Conversation
When having a JSON structure with nested data with a key ending (or being the same as the parent property to much is removed from the attribute when it is converted into a dotted key.
Example:
```json
{
"settings": {
"personal_settings": {
"darkmode": true
}
}
```
Without this fix a call to `getDottedAttributeKey` will give the attribute `personal_darkmode` instead of the expected `personal_settings.darkmode`.
Owner
|
@gisostallenberg, can you please post the code which defines the nested JSON field? |
Contributor
Author
|
Because the issue occurs in a private project the initial example is made up. JSON::make('settings', [
JSON::make('personal_settings', [
Boolean::make('darkmode', 'darkmode'),
])
]) |
Owner
|
Is there some other fields or panel defined which wraps around the JSON definition? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When having a JSON structure with nested data with a key ending (or being the same as the parent property to much is removed from the attribute when it is converted into a dotted key.
Example:
{ "settings": { "personal_settings": { "darkmode": true } }Without this fix a call to
getDottedAttributeKeywill give the attributepersonal_darkmodeinstead of the expectedpersonal_settings.darkmode.