Skip to content

feat(omp): accept advertised images in ACP chats - #1

Draft
NarryG wants to merge 1 commit into
review/omp-remaining-basefrom
feat/omp-acp-images
Draft

NarryG wants to merge 1 commit into
review/omp-remaining-basefrom
feat/omp-acp-images

Conversation

@NarryG

@NarryG NarryG commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

ELI5

OMP can receive pictures, but Orca sent a dragged PNG as a file reference. Native OMP chats now send the image when the running agent supports it; unsupported sessions still refuse images.

What Changed

  • Opt OMP into the existing ACP image path while keeping both the agent registry and live native capability checks.
  • Reuse OpenCode's bounded file/inline encoding without changing transport or UI components.
  • Cover admission, missing/false native capability, unsupported agents and file/inline byte preservation. Remove the obsolete registry-copy assertion and document support.

Why

The existing pipeline already handles images. One explicit opt-in avoids a second encoder and does not mistake a model label for native support.

Linked Issue

Fixes stablyai#30541

Visual Proof

Windows: before at 51530bb, after at 1440b798.

Before: file reference only.

Before: actual Orca sends a file reference

After: image thumbnail and native image delivery.

After: actual Orca renders and sends the PNG

Real OMP 18.12.2 received the original PNG bytes in a loaded session, and Stop cancelled the turn. Image understanding/model output was not tested.

Testing

  • Agent-driven check in the rebuilt Windows app: drag, Send, native PNG delivery and Stop.
  • Automated tests added/updated
  • Linux full lint, typecheck and all four pnpm test shards passed: run.
  • Windows full typecheck, build and changed-code quality passed. Focused tests: 25 passed; 8 failed on SQLite fixture cleanup (EBUSY). No fixture fix or assertion relaxation is included.
  • macOS, real SSH/WSL and mobile-device checks were not run.

AI Disclosure

OpenAI Codex GPT-6.1 Sol performed this integration and source inspection. Historical implementation/runtime and independent Spec review used GPT-6.1 Sol; independent Standards review used Claude Fable 5.1.

Review

  • Cross-platform/local/SSH: existing host-owned file reads and transport unchanged; no platform-specific product code. Folder workspaces supported; real SSH/WSL unrun.
  • Agents/integrations/compatibility: OMP-only opt-in, live capability still required, OpenCode covered. No wire changes or Git-provider dependency.
  • Performance/security: existing bounded reads/encoding; no extra probing, credential handling or resend logic.
  • UI/mobile: existing image composer/thumbnail reused; no styling or new controls. Fresh Windows application proof above; no renderer exceptions observed.

Agent skill upstream boundary

  • Not applicable: no upstream skill-installer material copied or mechanically translated.

Notes

No dependency or release-version changes.

Author

GitHub: @NarryG. X: @NarryOnTheNet.

Checklist

  • This PR is small and focused
  • ELI5, before/after, mechanism and choice explained
  • Genuine before/after screenshots attached with source revisions.
  • Source-reviewed for correctness, security and performance
  • Cross-platform, SSH/remote and compatibility impact considered
  • Required contribution checks completed; Windows-specific cleanup failures disclosed above.

@NarryG
NarryG force-pushed the feat/omp-acp-images branch from 575d173 to 1440b79 Compare October 19, 2026 08:38
@NarryG
NarryG changed the base branch from review/omp-parity-base to review/omp-remaining-base October 19, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant