Repository navigation
Conversation
NarryG
force-pushed
the
feat/acp-form-elicitation
branch
from
October 19, 2026 08:38
f5de96e to
cbee6df
Compare
NarryG
changed the base branch from
review/omp-parity-base
to
review/omp-remaining-base
October 19, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
OMP can ask you a question while it works, but native chat could not display its forms. Supported forms now appear in Orca's existing question cards. You can answer, decline or cancel; Full access never answers these human decisions for you.
What Changed
Opt OMP into form-only ACP elicitation when a handler is available. Translate supported choices, text, numbers and confirmations into existing desktop/mobile cards, then validate answers on the execution host. Keep the question and field instructions visible, including text-only asks. Preserve Other text, exclusive choices, empty values and omitted optional choices. Accept, decline and cancel stay distinct. Unsupported schemas fail explicitly; URL elicitation is not included.
Why
Reusing ACP and the existing question cards avoids another prompt framework. Bounded host validation prevents malformed or conflicting answers from becoming approval. Existing private request/authentication handling remains unchanged.
Linked Issue
Fixes stablyai#26924.
Visual Proof
Windows: before at
51530bb, after atcbee6dff.Before: same native command, no form cards.
After: OMP multi-select waits for the person under Full access.
Resolved answers, decline and cancel
Testing
pnpm testshards passed at the final head: run.EBUSY); no fixture workaround or skip is included.AI Disclosure
OpenAI Codex GPT-6.1 Sol assisted implementation, integration and review. Earlier independent Standards review used Claude Fable 5.1. Checks were agent-run, not human testing.
Review
Cross-platform: existing Node/TypeScript paths; no new OS-specific behavior. Local/folder/SSH: execution host owns validation and settlement. Agents: OMP opt-in only; other integrations unchanged. Compatibility: optional journal fields and existing answer transport; no new stream opcode or Git-provider assumption. Security/performance: bounded schemas and answers, no automatic approval or credential changes. UI/mobile: existing cards/tokens, visible question context and explicit decline/cancel; no new prompt framework.
Agent skill upstream boundary
Notes
Native timeouts without a withdrawal can leave a pending card; Stop clears it. Rendered checks were Windows-only; real SSH/WSL, mixed-peer, macOS and mobile devices were not tested. No dependency or release-version changes.
Author
GitHub @NarryG · X @NarryOnTheNet.
Checklist