Repository navigation
Conversation
NarryG
force-pushed
the
fix/omp-send-reconciliation
branch
from
October 19, 2026 08:38
9c90f4d to
7d6bfef
Compare
NarryG
changed the base branch from
review/omp-parity-base
to
review/omp-remaining-base
October 19, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
After a restart, Orca may not know whether OMP received your message. It can now check that chat's saved conversation for reliable evidence, without sending the message again. If the conversation cannot reopen, Orca warns that earlier context was lost instead of silently treating an uncertain chat as unused.
What Changed
Why
Saved conversation evidence is safer than guessing from terminal output or retrying a message that might already have arrived. Missing evidence never establishes non-delivery. This is separate from waiting for terminal writers to exit.
Linked Issue
Fixes stablyai#30542.
Visual Proof
Windows: before at
51530bb, after at7d6bfef. A controlled interrupted send remains uncertain and is not replayed; a failed reopen shows the existing lost-context warning.Before
After
Testing
pnpm typecheck,pnpm buildand changed-code quality passed.EBUSY); no assertions or application behavior were changed to hide them.pnpm testshards passed, alongside untouched upstream: run.AI Disclosure
OpenAI Codex GPT-6.1 Sol integrated this candidate. Earlier independent reviews used Codex and Claude Fable 5.1. Agent-driven checks are not human testing.
Review
Independent source review found no blocker. Windows/macOS/Linux paths, folder workspaces, execution-host ownership, supported agents/integrations, Git providers and backwards compatibility were checked. Only OMP gains a history reader; no new wire protocol or UI control. Reads reject symlinks, malformed UTF-8 and ambiguous ownership, and are limited to 16 MiB/100,000 records. Windows app verified; macOS, real SSH/WSL and mobile-device checks were not run.
Agent skill upstream boundary
Notes
No dependency or release-version changes.
Author
GitHub: @NarryG. X: @NarryOnTheNet.
Checklist