Skip to content

fix(native-chat): forward OMP's advertised /fast command - #5

Closed
NarryG wants to merge 1 commit into
review/omp-parity-basefrom
fix/omp-acp-fast-command
Closed

NarryG wants to merge 1 commit into
review/omp-parity-basefrom
fix/omp-acp-fast-command

Conversation

@NarryG

@NarryG NarryG commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

ELI5

OMP offers /fast in native chat, but Orca rejects it before it reaches OMP. This forwards it when the current OMP session reports support. Existing model and thinking controls stay unchanged.

What Changed

  • Let OMP handle /fast only when its live catalog lists it as a command.
  • Pass that catalog through the existing desktop and mobile send paths.
  • Add command/skill and unsupported-session regression coverage; update the native-chat docs.

Why

The running agent already owns this command. Reusing its catalog fixes the rejection without adding a Fast toggle or enabling unrelated commands. Other agents and unsupported sessions keep the existing guard.

Linked Issue

Fixes stablyai#30092.

Visual Proof

Before: offered in autocomplete, then rejected.

Before: Fast is rejected

After: /fast status works between two real Codex-backed OMP responses.

After: Fast works in native OMP chat

Testing

  • Automated UI check on Windows with OMP 18.12.1: autocomplete, Fast status/on/off, and real model responses before and after status.

  • Behavioral regression tests added.

  • pnpm typecheck and pnpm build: passed on Windows.

  • Focused tests: 49 shared tests and 26 mobile tests passed.

  • Linux lint, typecheck and changed-code checks passed.

  • Full Linux Node suite: not green. The serve-sim import error also fails on the unchanged base; a daemon listener assertion failed in the full run but passes in isolation on both base and candidate (comparison). Neither file is changed here.

AI Disclosure

OpenAI Codex GPT-6.1 Sol implemented and tested this. Independent reviews: GPT-6.1 Sol for issue requirements; Claude Fable 5.1 for repository standards.

Review

  • Cross-platform: shared TypeScript logic; no new paths, shortcuts or platform branches.
  • SSH/local/remote: uses the owning host's existing session catalog. No new remote calls; real SSH/WSL testing not performed.
  • Agents/compatibility: OMP-only, requires an explicit command entry; absent catalogs and skill entries retain refusal. No wire change or Git-provider dependency.
  • Performance/security: no new discovery, process, state store, credential handling or automatic resend.
  • UI/mobile: no layout changes; existing desktop and mobile send paths used. macOS app and physical mobile-device testing not performed.

Agent skill upstream boundary

  • Not applicable; no upstream skill-installer content copied.

Notes

Chat option ownership and standalone Codex Fast controls do not fix this OMP command guard. This PR adds no picker or option state.

Author: @NarryG · X: @NarryOnTheNet.

Checklist

  • Small and focused.
  • User-facing change, mechanism and alternative explained.
  • Actual before/after screenshots attached.
  • Reviewed for correctness, security and performance.
  • Cross-platform and SSH/remote impact considered.
  • Full suite entirely green; existing failures noted above. Upstream CI must pass before merge.

@NarryG
NarryG force-pushed the fix/omp-acp-fast-command branch from 20f5c5e to 9e2ca46 Compare October 19, 2026 07:01
@NarryG NarryG changed the title fix(omp): dispatch runtime-advertised ACP fast commands fix(native-chat): forward OMP's advertised /fast command Oct 19, 2026
@NarryG

NarryG commented Oct 19, 2026

Copy link
Copy Markdown
Owner Author

Closing our Fast draft in favor of maintainer-led Fast work. No upstream PR was opened.

@NarryG NarryG closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant