Repository navigation
Conversation
NarryG
force-pushed
the
fix/omp-acp-fast-command
branch
from
October 19, 2026 07:01
20f5c5e to
9e2ca46
Compare
Owner
Author
|
Closing our Fast draft in favor of maintainer-led Fast work. No upstream PR was opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
OMP offers
/fastin native chat, but Orca rejects it before it reaches OMP. This forwards it when the current OMP session reports support. Existing model and thinking controls stay unchanged.What Changed
/fastonly when its live catalog lists it as a command.Why
The running agent already owns this command. Reusing its catalog fixes the rejection without adding a Fast toggle or enabling unrelated commands. Other agents and unsupported sessions keep the existing guard.
Linked Issue
Fixes stablyai#30092.
Visual Proof
Before: offered in autocomplete, then rejected.
After:
/fast statusworks between two real Codex-backed OMP responses.Testing
Automated UI check on Windows with OMP 18.12.1: autocomplete, Fast status/on/off, and real model responses before and after status.
Behavioral regression tests added.
pnpm typecheckandpnpm build: passed on Windows.Focused tests: 49 shared tests and 26 mobile tests passed.
Linux lint, typecheck and changed-code checks passed.
Full Linux Node suite: not green. The
serve-simimport error also fails on the unchanged base; a daemon listener assertion failed in the full run but passes in isolation on both base and candidate (comparison). Neither file is changed here.AI Disclosure
OpenAI Codex GPT-6.1 Sol implemented and tested this. Independent reviews: GPT-6.1 Sol for issue requirements; Claude Fable 5.1 for repository standards.
Review
Agent skill upstream boundary
Notes
Chat option ownership and standalone Codex Fast controls do not fix this OMP command guard. This PR adds no picker or option state.
Author: @NarryG · X: @NarryOnTheNet.
Checklist