Skip to content

Change dev suite to enforce code quality and logging standards - #65

Merged
d-montgomery merged 8 commits into
NatLabRockies:mainfrom
TroyNSmith:newFeature
Aug 31, 2026
Merged

Change dev suite to enforce code quality and logging standards#65
d-montgomery merged 8 commits into
NatLabRockies:mainfrom
TroyNSmith:newFeature

Conversation

@TroyNSmith

Copy link
Copy Markdown
Collaborator

Added ruff, ty, pytest-cov, lefthook, import-linter, uv, and keepachangelog dependencies.
Removed black dependency (replaced with ruff / ty).
Fixed Lint / type errors identified by ruff and ty.

Notes:

  1. lefthook will run the pre-commit suite 1) when executing git commit and 2) as a part of the ci.yml GitHub workflow.
  2. Minimum testing coverage is currently set to enforce 20%. This should be bumped to at least 70-80% over time.
  3. CHANGES.md was replaced with CHANGELOG.md for version tracking.

See CHANGELOG.md for more information.

Comment thread pyproject.toml Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be updated to v3.0.2a1 while we are testing these updates.

Comment thread pyproject.toml
Comment thread fuellib/cli/format_code.py
Comment thread tests/baselinePredictions/posf10264.csv Outdated
Comment thread docs/development.rst

@d-montgomery d-montgomery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the dev suite @TroyNSmith! This is great stuff. I just have a few minor comments that need to be resolved as well as the failed tests related to coverage.

@d-montgomery

Copy link
Copy Markdown
Collaborator

I made a couple minor changes to the README, docs, and CI after testing this PR. I changed Lint-Format-Types back to Formatting because the main branch expects Formatting to pass before merging. Thanks again for the addition @TroyNSmith !

@d-montgomery
d-montgomery merged commit 2cd9fa5 into NatLabRockies:main Aug 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants