Input Data Updates: ATB 2025 and AEO 2026 - #82
Open
prateek-joshi-31 wants to merge 12 commits into
Open
Conversation
added 8 commits
March 26, 2026 16:01
prateek-joshi-31
requested review from
michaelavs and
paritoshdas
and
a balanced review from Copilot
September 3, 2026 12:25
There was a problem hiding this comment.
🟡 Changes recommended
All three depreciation scenarios contain empty 2022 commercial and industrial schedules that become invalid NaN inputs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds ATB 2025 scenario inputs supporting the broader ATB/AEO data refresh.
Changes:
- Adds advanced, moderate, and conservative PV/battery assumptions through 2050.
- Adds financing and depreciation schedules.
- Excludes generated and large local data artifacts.
File summaries
| File | Description |
|---|---|
dgen_os/input_data/pv_tech_performance/pv_tech_performance_atb25_moderate.csv |
Moderate PV performance |
dgen_os/input_data/pv_tech_performance/pv_tech_performance_atb25_conservative.csv |
Conservative PV performance |
dgen_os/input_data/pv_tech_performance/pv_tech_performance_atb25_advanced.csv |
Advanced PV performance |
dgen_os/input_data/pv_prices/pv_price_atb25_moderate.csv |
Moderate PV costs |
dgen_os/input_data/pv_prices/pv_price_atb25_conservative.csv |
Conservative PV costs |
dgen_os/input_data/pv_prices/pv_price_atb25_advanced.csv |
Advanced PV costs |
dgen_os/input_data/pv_plus_batt_prices/pv_plus_batt_price_atb25_moderate.csv |
Moderate combined-system costs |
dgen_os/input_data/pv_plus_batt_prices/pv_plus_batt_price_atb25_conservative.csv |
Conservative combined-system costs |
dgen_os/input_data/pv_plus_batt_prices/pv_plus_batt_price_atb25_advanced.csv |
Advanced combined-system costs |
dgen_os/input_data/financing_terms/financing_atb25_moderate.csv |
Moderate financing assumptions |
dgen_os/input_data/financing_terms/financing_atb25_conservative.csv |
Conservative financing assumptions |
dgen_os/input_data/financing_terms/financing_atb25_advanced.csv |
Advanced financing assumptions |
dgen_os/input_data/depreciation_schedules/depreciation_atb25_moderate.csv |
Moderate depreciation schedules |
dgen_os/input_data/depreciation_schedules/depreciation_atb25_conservative.csv |
Conservative depreciation schedules |
dgen_os/input_data/depreciation_schedules/depreciation_atb25_advanced.csv |
Advanced depreciation schedules |
dgen_os/input_data/batt_tech_performance/batt_tech_performance_atb25_moderate.csv |
Moderate battery performance |
dgen_os/input_data/batt_tech_performance/batt_tech_performance_atb25_conservative.csv |
Conservative battery performance |
dgen_os/input_data/batt_tech_performance/batt_tech_performance_atb25_advanced.csv |
Advanced battery performance |
dgen_os/input_data/batt_prices/batt_price_atb25_moderate.csv |
Moderate battery costs |
dgen_os/input_data/batt_prices/batt_price_atb25_conservative.csv |
Conservative battery costs |
dgen_os/input_data/batt_prices/batt_price_atb25_advanced.csv |
Advanced battery costs |
.gitignore |
Excludes generated and large inputs |
Review details
Suppressed comments (3)
dgen_os/input_data/depreciation_schedules/depreciation_atb25_moderate.csv:47
- The 2022 industrial schedule is empty, so
deprec_scheduleturns it into a six-element NaN list and 2022 industrial agents receive invalid depreciation inputs. Populate this row (and fix the generator’s 2022 gap so regeneration preserves it).
2022,ind,,,,,,
dgen_os/input_data/depreciation_schedules/depreciation_atb25_conservative.csv:47
- The 2022 industrial schedule is empty, so
deprec_scheduleturns it into a six-element NaN list and 2022 industrial agents receive invalid depreciation inputs. Populate this row (and fix the generator’s 2022 gap so regeneration preserves it).
2022,ind,,,,,,
dgen_os/input_data/depreciation_schedules/depreciation_atb25_advanced.csv:47
- The 2022 industrial schedule is empty, so
deprec_scheduleturns it into a six-element NaN list and 2022 industrial agents receive invalid depreciation inputs. Populate this row (and fix the generator’s 2022 gap so regeneration preserves it).
2022,ind,,,,,,
- Files reviewed: 21/45 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The default workbook references a financing filename that does not exist under the added naming scheme.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 21/45 changed files
- Comments generated: 1
- Review effort level: Balanced
| @@ -0,0 +1,38 @@ | |||
| year,economic_lifetime_yrs,loan_term_yrs_res,loan_interest_rate_res,down_payment_fraction_res,real_discount_rate_res,tax_rate_res,loan_term_yrs_nonres,loan_interest_rate_nonres,down_payment_fraction_nonres,real_discount_rate_nonres,tax_rate_nonres | |||
There was a problem hiding this comment.
Renamed the file to financing_atb25_moderate_r&d.csv to match the workbook reference in b8f5f8a.
Co-authored-by: prateek-joshi-31 <96447878+prateek-joshi-31@users.noreply.github.com>
Collaborator
Author
|
@michaelavs and @paritoshdas could you please review this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository is updated with input data from the 2025 Annual Technology Baseline (ATB) from NLR and the 2026 Annual Energy Outlook (AEO) from EIA.