Skip to content

Om refactor: classify cluster - #101

Merged
elenya-grant merged 10 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/system_specs
Aug 4, 2026
Merged

Om refactor: classify cluster#101
elenya-grant merged 10 commits into
NatLabRockies:developfrom
elenya-grant:om_refactor/system_specs

Conversation

@elenya-grant

@elenya-grant elenya-grant commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Om refactor: classify cluster

Added in components to classify the cluster design specs. This includes min and max production and consumption of the cluster. This introduces two main components:

  • CellClassification in electrolyzer/components/classifiers/cell_classifier.py: this uses the current bounds (I_min, I_max) and the current reference points (I_ref_points) and the other outputs from the reference cell in the cluster "converter" group to get the min/max values of the BOL design at the cell level.
  • CombineSerialComponents in electrolyzer/connectors/series_scalar.py: scales up multiple variable flows from from the cell level to the stack level or the stack level to the cluster level. 4 of these components are included in the classifier group.

These components are added to the cluster group as the classifier group.

Other additions

Also added in the ability to add a recorder to the problem. This is a quality-of-life improvement that will be nice for future dev. Added the method create_recorder into BERT (this will eventually get moved to a PoseOptimization class). This required adding in a function I wrote for H2I, make_unique_case_name, which was added to file_utils.py.

TODO:

  • add in subtests to the example to ensure these components are working as expected.

Related issue, if one exists

Does not fully resolve but is a step towards resolving Issue #97

Impacted areas of the software

  • create_cluster_classification_component() is the new method in electrolyzer/core/bert.py that creates the classifier group.

Additional supporting information

Test results, if applicable

@elenya-grant elenya-grant changed the title Om refactor: system specs Om refactor: classify cluster Aug 3, 2026
@elenya-grant
elenya-grant marked this pull request as ready for review August 3, 2026 22:25
@elenya-grant
elenya-grant merged commit cffc8e8 into NatLabRockies:develop Aug 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant