Om refactor: classify cluster - #101
Merged
elenya-grant merged 10 commits intoAug 4, 2026
Merged
Conversation
…e input parameters
…rameters changes results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Om refactor: classify cluster
Added in components to classify the cluster design specs. This includes min and max production and consumption of the cluster. This introduces two main components:
CellClassificationinelectrolyzer/components/classifiers/cell_classifier.py: this uses the current bounds (I_min,I_max) and the current reference points (I_ref_points) and the other outputs from the reference cell in the cluster "converter" group to get the min/max values of the BOL design at the cell level.CombineSerialComponentsinelectrolyzer/connectors/series_scalar.py: scales up multiple variable flows from from the cell level to the stack level or the stack level to the cluster level. 4 of these components are included in theclassifiergroup.These components are added to the cluster group as the
classifiergroup.Other additions
Also added in the ability to add a recorder to the problem. This is a quality-of-life improvement that will be nice for future dev. Added the method
create_recorderintoBERT(this will eventually get moved to a PoseOptimization class). This required adding in a function I wrote for H2I,make_unique_case_name, which was added tofile_utils.py.TODO:
Related issue, if one exists
Does not fully resolve but is a step towards resolving Issue #97
Impacted areas of the software
create_cluster_classification_component()is the new method inelectrolyzer/core/bert.pythat creates theclassifiergroup.Additional supporting information
Test results, if applicable