OM Refactor: Scale Simulation Results - #103
Merged
elenya-grant merged 2 commits intoAug 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OM Refactor: Scale Simulation Results
Feature or improvement description
Added a 3 new subsystems to the cluster 'simulation' component. One of these is a new model, called a degradation combiner. This does two calcs:
The two other subsystems utilize the
CombineSerialComponentscomponent to scale cell-level simulation results to the cluster level. The power and voltage from the degradation combiner are input to the first scale-up component, and the current density, hydrogen production, and o2 production from thecell_realcomponent are connected to the first scale up component. The first scale up component is connected to another scale-up component (stack to cluster). The last scale-up component promotes the outputs from a naming convention of{var}_outtoCluster_{var}(so the cluster-level simulation outputs are namedCluster0.simulation.Cluster_H2for example).In the future, the H2 and O2 would be connected to the scale-up component from a losses group, the subtracts hydrogen losses due to warm-up delays.
Related issue, if one exists
Impacted areas of the software
New file:
electrolyzer/connectors/series_scalar.pyModified files:
electrolyzer/core/bert.py: updatedcreate_cluster_simulation_blockandcreate_componentselectrolyzer/test/test_om_examples.py::test_example_00_no_controller: added some basic subtests for the outputs of the new model.Additional supporting information
Test results, if applicable