update examples and docs for RdTools 3#429
Conversation
|
To do: Get the example file on the DuraMAT datahub updated to include the NSRDB data |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## aggregated_filters_for_trials #429 +/- ##
==============================================================
Coverage 96.10% 96.10%
==============================================================
Files 11 11
Lines 2208 2209 +1
==============================================================
+ Hits 2122 2123 +1
Misses 86 86 ☔ View full report in Codecov by Sentry. |
|
@martin-springer @kandersolar Any ideas on how I managed to break the nbval tests here? |
@mdeceglie - A missing comma in the workflow file and upload-artifact had to be updated to v4. There's an issue tough with the newer version of nbval ignoring the semicolon: computationalmodelling/nbval#194 Unfortunately, that bug hasn't been fixed in 0.11 either. We need to decide on how we want to address that. |
|
@kandersolar Is it time to remove the experimental warning from the availability module? Seems pretty locked in, we've used it in a number of different applications successfully, and I'm not aware of plans to modify it. |
|
I have no plans to change the method either. No objection from me on removing the warning. |
martin-springer
left a comment
There was a problem hiding this comment.
Looking great! I only found a few minor things.
__init__.py