Skip to content

Adding Key Compression to BTree (Head + Tail) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomijaga wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding Key Compression to BTree (Head + Tail) #7

tomijaga wants to merge 3 commits into from

Conversation

@tomijaga
Copy link
Member

@tomijaga tomijaga commented Jul 23, 2025 •
edited
Loading

Breaking at commit 71e7b92: The PR Cannot be merged to main without a major version update to v1.0.0

@github-actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Benchmark Results

Unexpected error. Stopping replica...
file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/node_modules/execa/lib/return/final-error.js:6
return new ErrorClass(message, options);
^

ExecaError: Command failed with exit code 1: /home/runner/.cache/mops/moc/0.15.1/moc -c --idl canister.mo --force-gc --incremental-gc --release --package base '../../base@0.14.11/src' --package itertools '../../itertools@0.2.2/src' --package memory-region '../../memory-region@1.2.4/src' --package stableheapbtreemap '../../stableheapbtreemap@1.5.0/src' --package map '../../map@9.0.1/src' --package augmented-btrees '../../augmented-btrees@0.5.2/src' --package buffer-deque '../../buffer-deque@0.1.0/src' --package byte-utils '../../byte-utils@0.0.1/src' --package xtended-numbers '../../xtended-numbers@0.4.0/src' --package test '../../test@2.1.1/src' --package bench '../../bench@1.0.0/src' --package fuzz '../../fuzz@1.0.0/src' --package MotokoStableBTree '../../_github/MotokoStableBTree#master@b590ede4489c2d4b2189299c3a2cc35dc4faa3fc/src' --package memory-collection-btree-v0-v0_0_1_migration '../../_github/memory-collection-btree-v0-v0_0_1_migration#master@bdba9e3/src'

../../../src/Utils.mo:162.22-162.23: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)
../../../src/Utils.mo:187.18-187.19: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)
../../../src/MemoryBTree/Migrations/lib.mo:25.23-25.25: warning [M0194], unused identifier v0 (delete or rename to wildcard _ or _v0)
../../../src/MemoryBTree/Migrations/lib.mo:28.27-28.33: warning [M0194], unused identifier v0_0_1 (delete or rename to wildcard _ or _v0_0_1)
../../../src/MemoryBTree/modules/Leaf.mo:142.83-142.92: warning [M0194], unused identifier load_keys (delete or rename to wildcard _ or _load_keys)
../../../src/MemoryBTree/modules/Leaf.mo:268.25-268.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)
../../../src/MemoryBTree/modules/Leaf.mo:268.46-268.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)
../../../src/MemoryBTree/modules/Leaf.mo:268.82-268.94: warning [M0194], unused identifier leaf_address (delete or rename to wildcard _ or _leaf_address)
../../../src/MemoryBTree/modules/Branch.mo:78.48-78.90: warning [M0155], operator may trap for inferred type
Nat
../../../src/MemoryBTree/modules/Branch.mo:278.25-278.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)
../../../src/MemoryBTree/modules/Branch.mo:278.46-278.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)
../../../src/MemoryBTree/modules/Branch.mo:278.82-278.96: warning [M0194], unused identifier branch_address (delete or rename to wildcard _ or _branch_address)
../../../src/MemoryBTree/modules/Branch.mo:439.13-439.23: warning [M0194], unused identifier leaf_depth (delete or rename to wildcard _ or _leaf_depth)
../../../src/MemoryBTree/modules/Branch.mo:440.13-440.25: warning [M0194], unused identifier branch_depth (delete or rename to wildcard _ or _branch_depth)
../../../src/MemoryBTree/modules/Branch.mo:1039.22-1039.30: warning [M0194], unused identifier key_blob (delete or rename to wildcard _ or _key_blob)
../../../src/MemoryBTree/Base.mo:51.13-51.23: warning [M0194], unused identifier cache_size (delete or rename to wildcard _ or _cache_size)
../../../src/MemoryBTree/Base.mo:451.54-451.65: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)
../../../src/MemoryBTree/Base.mo:457.56-457.67: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)
canister.mo:27.2-27.36: type error [M0219], this declaration is currently implicitly transient, please declare it explicitly transient
at getFinalError (file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/node_modules/execa/lib/return/final-error.js:6:9)
at makeError (file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/node_modules/execa/lib/return/result.js:108:16)
at getAsyncResult (file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/node_modules/execa/lib/methods/main-async.js:167:4)
at handlePromise (file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/node_modules/execa/lib/methods/main-async.js:150:17)
at async deployBenchFile (file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/dist/commands/bench.js:206:5)
at async file:///opt/hostedtoolcache/node/20.19.4/x64/lib/node_modules/ic-mops/dist/commands/bench.js:110:13 {
shortMessage: "Command failed with exit code 1: /home/runner/.cache/mops/moc/0.15.1/moc -c --idl canister.mo --force-gc --incremental-gc --release --package base '../../base@0.14.11/src' --package itertools '../../itertools@0.2.2/src' --package memory-region '../../memory-region@1.2.4/src' --package stableheapbtreemap '../../stableheapbtreemap@1.5.0/src' --package map '../../map@9.0.1/src' --package augmented-btrees '../../augmented-btrees@0.5.2/src' --package buffer-deque '../../buffer-deque@0.1.0/src' --package byte-utils '../../byte-utils@0.0.1/src' --package xtended-numbers '../../xtended-numbers@0.4.0/src' --package test '../../test@2.1.1/src' --package bench '../../bench@1.0.0/src' --package fuzz '../../fuzz@1.0.0/src' --package MotokoStableBTree '../../_github/MotokoStableBTree#master@b590ede4489c2d4b2189299c3a2cc35dc4faa3fc/src' --package memory-collection-btree-v0-v0_0_1_migration '../../_github/memory-collection-btree-v0-v0_0_1_migration#master@bdba9e3/src'",
command: '/home/runner/.cache/mops/moc/0.15.1/moc -c --idl canister.mo --force-gc --incremental-gc --release --package base ../../base@0.14.11/src --package itertools ../../itertools@0.2.2/src --package memory-region ../../memory-region@1.2.4/src --package stableheapbtreemap ../../stableheapbtreemap@1.5.0/src --package map ../../map@9.0.1/src --package augmented-btrees ../../augmented-btrees@0.5.2/src --package buffer-deque ../../buffer-deque@0.1.0/src --package byte-utils ../../byte-utils@0.0.1/src --package xtended-numbers ../../xtended-numbers@0.4.0/src --package test ../../test@2.1.1/src --package bench ../../bench@1.0.0/src --package fuzz ../../fuzz@1.0.0/src --package MotokoStableBTree ../../_github/MotokoStableBTree#master@b590ede4489c2d4b2189299c3a2cc35dc4faa3fc/src --package memory-collection-btree-v0-v0_0_1_migration ../../_github/memory-collection-btree-v0-v0_0_1_migration#master@bdba9e3/src',
escapedCommand: "/home/runner/.cache/mops/moc/0.15.1/moc -c --idl canister.mo --force-gc --incremental-gc --release --package base '../../base@0.14.11/src' --package itertools '../../itertools@0.2.2/src' --package memory-region '../../memory-region@1.2.4/src' --package stableheapbtreemap '../../stableheapbtreemap@1.5.0/src' --package map '../../map@9.0.1/src' --package augmented-btrees '../../augmented-btrees@0.5.2/src' --package buffer-deque '../../buffer-deque@0.1.0/src' --package byte-utils '../../byte-utils@0.0.1/src' --package xtended-numbers '../../xtended-numbers@0.4.0/src' --package test '../../test@2.1.1/src' --package bench '../../bench@1.0.0/src' --package fuzz '../../fuzz@1.0.0/src' --package MotokoStableBTree '../../_github/MotokoStableBTree#master@b590ede4489c2d4b2189299c3a2cc35dc4faa3fc/src' --package memory-collection-btree-v0-v0_0_1_migration '../../_github/memory-collection-btree-v0-v0_0_1_migration#master@bdba9e3/src'",
cwd: '/home/runner/work/memory-collection/memory-collection/.mops/.bench/BTree-specific-fns.bench',
durationMs: 766.355461,
failed: true,
timedOut: false,
isCanceled: false,
isGracefullyCanceled: false,
isTerminated: false,
isMaxBuffer: false,
isForcefullyTerminated: false,
exitCode: 1,
stderr: '../../../src/Utils.mo:162.22-162.23: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)\n' +
'../../../src/Utils.mo:187.18-187.19: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)\n' +
'../../../src/MemoryBTree/Migrations/lib.mo:25.23-25.25: warning [M0194], unused identifier v0 (delete or rename to wildcard _ or _v0)\n' +
'../../../src/MemoryBTree/Migrations/lib.mo:28.27-28.33: warning [M0194], unused identifier v0_0_1 (delete or rename to wildcard _ or _v0_0_1)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:142.83-142.92: warning [M0194], unused identifier load_keys (delete or rename to wildcard _ or _load_keys)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.25-268.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.46-268.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.82-268.94: warning [M0194], unused identifier leaf_address (delete or rename to wildcard _ or _leaf_address)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:78.48-78.90: warning [M0155], operator may trap for inferred type\n' +
' Nat\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.25-278.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.46-278.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.82-278.96: warning [M0194], unused identifier branch_address (delete or rename to wildcard _ or _branch_address)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:439.13-439.23: warning [M0194], unused identifier leaf_depth (delete or rename to wildcard _ or _leaf_depth)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:440.13-440.25: warning [M0194], unused identifier branch_depth (delete or rename to wildcard _ or _branch_depth)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:1039.22-1039.30: warning [M0194], unused identifier key_blob (delete or rename to wildcard _ or _key_blob)\n' +
'../../../src/MemoryBTree/Base.mo:51.13-51.23: warning [M0194], unused identifier cache_size (delete or rename to wildcard _ or _cache_size)\n' +
'../../../src/MemoryBTree/Base.mo:451.54-451.65: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/Base.mo:457.56-457.67: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'canister.mo:27.2-27.36: type error [M0219], this declaration is currently implicitly transient, please declare it explicitly transient',
stdio: [
undefined,
undefined,
'../../../src/Utils.mo:162.22-162.23: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)\n' +
'../../../src/Utils.mo:187.18-187.19: warning [M0194], unused identifier i (delete or rename to wildcard _ or _i)\n' +
'../../../src/MemoryBTree/Migrations/lib.mo:25.23-25.25: warning [M0194], unused identifier v0 (delete or rename to wildcard _ or _v0)\n' +
'../../../src/MemoryBTree/Migrations/lib.mo:28.27-28.33: warning [M0194], unused identifier v0_0_1 (delete or rename to wildcard _ or _v0_0_1)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:142.83-142.92: warning [M0194], unused identifier load_keys (delete or rename to wildcard _ or _load_keys)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.25-268.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.46-268.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/modules/Leaf.mo:268.82-268.94: warning [M0194], unused identifier leaf_address (delete or rename to wildcard _ or _leaf_address)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:78.48-78.90: warning [M0155], operator may trap for inferred type\n' +
' Nat\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.25-278.30: warning [M0194], unused identifier btree (delete or rename to wildcard _ or _btree)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.46-278.57: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:278.82-278.96: warning [M0194], unused identifier branch_address (delete or rename to wildcard _ or _branch_address)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:439.13-439.23: warning [M0194], unused identifier leaf_depth (delete or rename to wildcard _ or _leaf_depth)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:440.13-440.25: warning [M0194], unused identifier branch_depth (delete or rename to wildcard _ or _branch_depth)\n' +
'../../../src/MemoryBTree/modules/Branch.mo:1039.22-1039.30: warning [M0194], unused identifier key_blob (delete or rename to wildcard _ or _key_blob)\n' +
'../../../src/MemoryBTree/Base.mo:51.13-51.23: warning [M0194], unused identifier cache_size (delete or rename to wildcard _ or _cache_size)\n' +
'../../../src/MemoryBTree/Base.mo:451.54-451.65: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'../../../src/MemoryBTree/Base.mo:457.56-457.67: warning [M0194], unused identifier btree_utils (delete or rename to wildcard _ or _btree_utils)\n' +
'canister.mo:27.2-27.36: type error [M0219], this declaration is currently implicitly transient, please declare it explicitly transient'
],
ipcOutput: [],
pipedFrom: []
}

Node.js v20.19.4

@tomijaga tomijaga mentioned this pull request Aug 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomijaga